Skip to content

Commit d0afea9

Browse files
committed
Make RequestId only settable internally
1 parent 9ded84a commit d0afea9

File tree

5 files changed

+18
-12
lines changed

5 files changed

+18
-12
lines changed

dotnet/src/webdriver/DevTools/v130/V130Network.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,12 +339,14 @@ private void OnFetchRequestPaused(object? sender, Fetch.RequestPausedEventArgs e
339339
{
340340
var requestData = new HttpRequestData
341341
(
342-
requestId: e.RequestId,
343342
method: e.Request.Method,
344343
url: e.Request.Url,
345344
postData: e.Request.PostData,
346345
headers: new Dictionary<string, string>(e.Request.Headers)
347-
);
346+
)
347+
{
348+
RequestId = e.RequestId
349+
};
348350

349351
RequestPausedEventArgs wrapped = new RequestPausedEventArgs(null, requestData);
350352
this.OnRequestPaused(wrapped);

dotnet/src/webdriver/DevTools/v131/V131Network.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,12 +339,14 @@ private void OnFetchRequestPaused(object? sender, Fetch.RequestPausedEventArgs e
339339
{
340340
var requestData = new HttpRequestData
341341
(
342-
requestId: e.RequestId,
343342
method: e.Request.Method,
344343
url: e.Request.Url,
345344
postData: e.Request.PostData,
346345
headers: new Dictionary<string, string>(e.Request.Headers)
347-
);
346+
)
347+
{
348+
RequestId = e.RequestId
349+
};
348350

349351
RequestPausedEventArgs wrapped = new RequestPausedEventArgs(null, requestData);
350352
this.OnRequestPaused(wrapped);

dotnet/src/webdriver/DevTools/v132/V132Network.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,12 +339,14 @@ private void OnFetchRequestPaused(object? sender, Fetch.RequestPausedEventArgs e
339339
{
340340
var requestData = new HttpRequestData
341341
(
342-
requestId: e.RequestId,
343342
method: e.Request.Method,
344343
url: e.Request.Url,
345344
postData: e.Request.PostData,
346345
headers: new Dictionary<string, string>(e.Request.Headers)
347-
);
346+
)
347+
{
348+
RequestId = e.RequestId
349+
};
348350

349351
RequestPausedEventArgs wrapped = new RequestPausedEventArgs(null, requestData);
350352
this.OnRequestPaused(wrapped);

dotnet/src/webdriver/DevTools/v85/V85Network.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,12 +336,14 @@ private void OnFetchRequestPaused(object? sender, Fetch.RequestPausedEventArgs e
336336
{
337337
var requestData = new HttpRequestData
338338
(
339-
requestId: e.RequestId,
340339
method: e.Request.Method,
341340
url: e.Request.Url,
342341
postData: e.Request.PostData,
343342
headers: new Dictionary<string, string>(e.Request.Headers)
344-
);
343+
)
344+
{
345+
RequestId = e.RequestId
346+
};
345347

346348
RequestPausedEventArgs wrapped = new RequestPausedEventArgs(null, requestData);
347349
this.OnRequestPaused(wrapped);

dotnet/src/webdriver/HttpRequestData.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,12 @@ public HttpRequestData()
4242
/// <param name="url">The URL of the HTTP request.</param>
4343
/// <param name="postData">The POST data of the HTTP request.</param>
4444
/// <param name="headers">The headers of the HTTP request.</param>
45-
/// <param name="requestId">The ID of the HTTP request.</param>
46-
public HttpRequestData(string method, string url, string? postData, Dictionary<string, string> headers, string requestId)
45+
public HttpRequestData(string method, string url, string? postData, Dictionary<string, string> headers)
4746
{
4847
this.Method = method;
4948
this.Url = url;
5049
this.PostData = postData;
5150
this.Headers = headers;
52-
this.RequestId = requestId;
5351
}
5452

5553
/// <summary>
@@ -75,6 +73,6 @@ public HttpRequestData(string method, string url, string? postData, Dictionary<s
7573
/// <summary>
7674
/// Gets the ID of the HTTP request.
7775
/// </summary>
78-
public string? RequestId { get; }
76+
public string? RequestId { get; internal set; }
7977
}
8078
}

0 commit comments

Comments
 (0)