Merge remote-tracking branch 'origin/rb_add_support_for_chrome_beta' into rb_add_support_for_chrome_beta

# Conflicts:
#	common/repositories.bzl

Author: aguspe

.github/workflows/bazel.yml

@@ -122,7 +122,7 @@ jobs:
           node-version: ${{ inputs.node-version }}
       - name: Setup Bazel with caching
         if: inputs.caching
-        uses: bazel-contrib/setup-bazel@0.13.0
+        uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
           bazelrc: common --color=yes
@@ -136,7 +136,7 @@ jobs:
           repository-cache: true
       - name: Setup Bazel without caching
         if: inputs.caching == false
-        uses: bazel-contrib/setup-bazel@0.13.0
+        uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelrc: common --color=yes
       - name: Setup curl for Ubuntu

.github/workflows/ci.yml

@@ -25,7 +25,7 @@ jobs:
         with:
           fetch-depth: 50
       - name: Setup Bazel
-        uses: bazel-contrib/setup-bazel@0.13.0
+        uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
           cache-version: 2

.gitignore

@@ -75,6 +75,7 @@ py/selenium/webdriver/remote/getAttribute.js
 py/selenium/webdriver/remote/isDisplayed.js
 py/docs/build/
 py/docs/source/**/*
+!py/docs/source/conf.py
 py/build/
 py/LICENSE
 py/pytestdebug.log

MODULE.bazel

@@ -1,7 +1,6 @@
 module(name = "selenium")
 
 bazel_dep(name = "apple_rules_lint", version = "0.4.0")
-bazel_dep(name = "aspect_rules_lint", version = "1.4.2")
 bazel_dep(name = "aspect_bazel_lib", version = "2.13.0")
 bazel_dep(name = "aspect_rules_esbuild", version = "0.21.0")
 bazel_dep(name = "aspect_rules_js", version = "2.3.7")
@@ -21,6 +20,7 @@ bazel_dep(name = "rules_cc", version = "0.1.1", dev_dependency = True)
 bazel_dep(name = "rules_dotnet", version = "0.17.5")
 bazel_dep(name = "rules_java", version = "8.7.1")
 bazel_dep(name = "rules_jvm_external", version = "6.6")
+bazel_dep(name = "rules_multitool", version = "1.3.0")
 bazel_dep(name = "rules_nodejs", version = "6.3.2")
 bazel_dep(name = "rules_oci", version = "1.8.0")
 bazel_dep(name = "rules_pkg", version = "1.0.1")
@@ -37,6 +37,10 @@ git_override(
     remote = "https://github.com/bazel-contrib/rules_jvm_external.git",
 )
 
+multitool = use_extension("@rules_multitool//multitool:extension.bzl", "multitool")
+multitool.hub(lockfile = "//:multitool.lock.json")
+use_repo(multitool, "multitool")
+
 linter = use_extension("@apple_rules_lint//lint:extensions.bzl", "linter")
 linter.configure(
     name = "java-spotbugs",

common/mirror/selenium

@@ -3,13 +3,33 @@
     "tag_name": "nightly",
     "assets": [
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.33.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.34.0-SNAPSHOT.zip"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.33.0-SNAPSHOT.jar"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.34.0-SNAPSHOT.jar"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.33.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.34.0-SNAPSHOT.zip"
+      }
+    ]
+  },
+  {
+    "tag_name": "selenium-4.33.0",
+    "assets": [
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.33.0/selenium-dotnet-4.33.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.33.0/selenium-dotnet-strongnamed-4.33.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.33.0/selenium-java-4.33.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.33.0/selenium-server-4.33.0.jar"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.33.0/selenium-server-4.33.0.zip"
       }
     ]
   },
@@ -836,25 +856,5 @@
         "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.5.0/selenium-server-4.5.3.zip"
       }
     ]
-  },
-  {
-    "tag_name": "selenium-4.4.0",
-    "assets": [
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.4.0/selenium-dotnet-4.4.0.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.4.0/selenium-dotnet-strongnamed-4.4.0.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.4.0/selenium-java-4.4.0.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.4.0/selenium-server-4.4.0.jar"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.4.0/selenium-server-4.4.0.zip"
-      }
-    ]
   }
 ]

dotnet/src/webdriver/BiDi/BiDi.cs

@@ -27,41 +27,41 @@ public class BiDi : IAsyncDisposable
 {
     private readonly Broker _broker;
 
-    private readonly Lazy<Modules.Session.SessionModule> _sessionModule;
-    private readonly Lazy<Modules.BrowsingContext.BrowsingContextModule> _browsingContextModule;
-    private readonly Lazy<Modules.Browser.BrowserModule> _browserModule;
-    private readonly Lazy<Modules.Network.NetworkModule> _networkModule;
-    private readonly Lazy<Modules.Input.InputModule> _inputModule;
-    private readonly Lazy<Modules.Script.ScriptModule> _scriptModule;
-    private readonly Lazy<Modules.Log.LogModule> _logModule;
-    private readonly Lazy<Modules.Storage.StorageModule> _storageModule;
+    private readonly Lazy<Session.SessionModule> _sessionModule;
+    private readonly Lazy<BrowsingContext.BrowsingContextModule> _browsingContextModule;
+    private readonly Lazy<Browser.BrowserModule> _browserModule;
+    private readonly Lazy<Network.NetworkModule> _networkModule;
+    private readonly Lazy<Input.InputModule> _inputModule;
+    private readonly Lazy<Script.ScriptModule> _scriptModule;
+    private readonly Lazy<Log.LogModule> _logModule;
+    private readonly Lazy<Storage.StorageModule> _storageModule;
 
     internal BiDi(string url)
     {
         var uri = new Uri(url);
 
         _broker = new Broker(this, uri);
 
-        _sessionModule = new Lazy<Modules.Session.SessionModule>(() => new Modules.Session.SessionModule(_broker));
-        _browsingContextModule = new Lazy<Modules.BrowsingContext.BrowsingContextModule>(() => new Modules.BrowsingContext.BrowsingContextModule(_broker));
-        _browserModule = new Lazy<Modules.Browser.BrowserModule>(() => new Modules.Browser.BrowserModule(_broker));
-        _networkModule = new Lazy<Modules.Network.NetworkModule>(() => new Modules.Network.NetworkModule(_broker));
-        _inputModule = new Lazy<Modules.Input.InputModule>(() => new Modules.Input.InputModule(_broker));
-        _scriptModule = new Lazy<Modules.Script.ScriptModule>(() => new Modules.Script.ScriptModule(_broker));
-        _logModule = new Lazy<Modules.Log.LogModule>(() => new Modules.Log.LogModule(_broker));
-        _storageModule = new Lazy<Modules.Storage.StorageModule>(() => new Modules.Storage.StorageModule(_broker));
+        _sessionModule = new Lazy<Session.SessionModule>(() => new Session.SessionModule(_broker));
+        _browsingContextModule = new Lazy<BrowsingContext.BrowsingContextModule>(() => new BrowsingContext.BrowsingContextModule(_broker));
+        _browserModule = new Lazy<Browser.BrowserModule>(() => new Browser.BrowserModule(_broker));
+        _networkModule = new Lazy<Network.NetworkModule>(() => new Network.NetworkModule(_broker));
+        _inputModule = new Lazy<Input.InputModule>(() => new Input.InputModule(_broker));
+        _scriptModule = new Lazy<Script.ScriptModule>(() => new Script.ScriptModule(_broker));
+        _logModule = new Lazy<Log.LogModule>(() => new Log.LogModule(_broker));
+        _storageModule = new Lazy<Storage.StorageModule>(() => new Storage.StorageModule(_broker));
     }
 
-    internal Modules.Session.SessionModule SessionModule => _sessionModule.Value;
-    public Modules.BrowsingContext.BrowsingContextModule BrowsingContext => _browsingContextModule.Value;
-    public Modules.Browser.BrowserModule Browser => _browserModule.Value;
-    public Modules.Network.NetworkModule Network => _networkModule.Value;
-    internal Modules.Input.InputModule InputModule => _inputModule.Value;
-    public Modules.Script.ScriptModule Script => _scriptModule.Value;
-    public Modules.Log.LogModule Log => _logModule.Value;
-    public Modules.Storage.StorageModule Storage => _storageModule.Value;
+    internal Session.SessionModule SessionModule => _sessionModule.Value;
+    public BrowsingContext.BrowsingContextModule BrowsingContext => _browsingContextModule.Value;
+    public Browser.BrowserModule Browser => _browserModule.Value;
+    public Network.NetworkModule Network => _networkModule.Value;
+    internal Input.InputModule InputModule => _inputModule.Value;
+    public Script.ScriptModule Script => _scriptModule.Value;
+    public Log.LogModule Log => _logModule.Value;
+    public Storage.StorageModule Storage => _storageModule.Value;
 
-    public Task<Modules.Session.StatusResult> StatusAsync()
+    public Task<Session.StatusResult> StatusAsync()
     {
         return SessionModule.StatusAsync();
     }
@@ -75,7 +75,7 @@ public static async Task<BiDi> ConnectAsync(string url)
         return bidi;
     }
 
-    public Task EndAsync(Modules.Session.EndOptions? options = null)
+    public Task EndAsync(Session.EndOptions? options = null)
     {
         return SessionModule.EndAsync(options);
     }

dotnet/src/webdriver/BiDi/Modules/Browser/BrowserModule.cs renamed to dotnet/src/webdriver/BiDi/Browser/BrowserModule.cs

@@ -17,11 +17,10 @@
 // under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using System.Threading.Tasks;
 using OpenQA.Selenium.BiDi.Communication;
 
-namespace OpenQA.Selenium.BiDi.Modules.Browser;
+namespace OpenQA.Selenium.BiDi.Browser;
 
 public sealed class BrowserModule(Broker broker) : Module(broker)
 {
@@ -32,7 +31,9 @@ public async Task CloseAsync(CloseOptions? options = null)
 
     public async Task<UserContextInfo> CreateUserContextAsync(CreateUserContextOptions? options = null)
     {
-        return await Broker.ExecuteCommandAsync<CreateUserContextCommand, UserContextInfo>(new CreateUserContextCommand(), options).ConfigureAwait(false);
+        var @params = new CreateUserContextCommandParameters(options?.AcceptInsecureCerts, options?.Proxy);
+
+        return await Broker.ExecuteCommandAsync<CreateUserContextCommand, UserContextInfo>(new CreateUserContextCommand(@params), options).ConfigureAwait(false);
     }
 
     public async Task<GetUserContextsResult> GetUserContextsAsync(GetUserContextsOptions? options = null)

dotnet/src/webdriver/BiDi/Modules/Browser/ClientWindow.cs renamed to dotnet/src/webdriver/BiDi/Browser/ClientWindow.cs

@@ -17,7 +17,7 @@
 // under the License.
 // </copyright>
 
-namespace OpenQA.Selenium.BiDi.Modules.Browser;
+namespace OpenQA.Selenium.BiDi.Browser;
 
 public record ClientWindow
 {

dotnet/src/webdriver/BiDi/Modules/Browser/ClientWindowInfo.cs renamed to dotnet/src/webdriver/BiDi/Browser/ClientWindowInfo.cs

@@ -17,7 +17,7 @@
 // under the License.
 // </copyright>
 
-namespace OpenQA.Selenium.BiDi.Modules.Browser;
+namespace OpenQA.Selenium.BiDi.Browser;
 
 public record ClientWindowInfo(bool Active, ClientWindow ClientWindow, ClientWindowState State, int Height, int Width, int X, int Y);
 

dotnet/src/webdriver/BiDi/Modules/Browser/CloseCommand.cs renamed to dotnet/src/webdriver/BiDi/Browser/CloseCommand.cs

@@ -19,7 +19,7 @@
 
 using OpenQA.Selenium.BiDi.Communication;
 
-namespace OpenQA.Selenium.BiDi.Modules.Browser;
+namespace OpenQA.Selenium.BiDi.Browser;
 
 internal class CloseCommand()
     : Command<CommandParameters, EmptyResult>(CommandParameters.Empty, "browser.close");