Firefox: Adding an extra check to result wrapper. Fixes issue #1426

barancev · barancev · commit d1e9b2760c1b · 2016-01-23T23:55:55.000+03:00
diff --git a/javascript/firefox-driver/js/utils.js b/javascript/firefox-driver/js/utils.js
@@ -734,7 +734,7 @@ Utils.wrapResult = function(result, doc) {
       }
 
       // There's got to be a more intelligent way of detecting this.
-      if (result['tagName']) {
+      if (result.nodeType == 1 && result['tagName']) {
         return {'ELEMENT': Utils.addToKnownElements(result)};
       }
 

Original file line number	Diff line number	Diff line change
`@@ -734,7 +734,7 @@ Utils.wrapResult = function(result, doc) {`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`// There's got to be a more intelligent way of detecting this.`
`737`		`- if (result['tagName']) {`
	`737`	`+ if (result.nodeType == 1 && result['tagName']) {`
`738`	`738`	`return {'ELEMENT': Utils.addToKnownElements(result)};`
`739`	`739`	`}`
`740`	`740`