Merge branch 'trunk' into annotate-relative-by

Author: gryznar

.bazelignore

@@ -23,5 +23,5 @@ java/build/production
 java/client/build
 java/server/build
 javascript/grid-ui/node_modules
-javascript/node/selenium-webdriver/node_modules
+javascript/selenium-webdriver/node_modules
 node_modules

.bazelrc

@@ -8,7 +8,11 @@ try-import %workspace%/.bazelrc.windows.local
 # https://github.com/bazelbuild/bazel/issues/20369
 # https://github.com/bazelbuild/bazel/issues/21491
 
-common --enable_bzlmod --lockfile_mode=off
+common --lockfile_mode=off
+
+# Prepare for Bazel 8. These become the default in 8.0.0
+common --incompatible_disallow_empty_glob
+common --incompatible_use_plus_in_repo_names
 
 # Ensure Windows support is accurate.
 
@@ -20,10 +24,10 @@ build --flag_alias=headless=//common:headless
 
 # Set the default java toolchain
 
-build --java_language_version=17
-build --java_runtime_version=remotejdk_17
-build --tool_java_language_version=17
-build --tool_java_runtime_version=remotejdk_17
+build --java_language_version=21
+build --java_runtime_version=remotejdk_21
+build --tool_java_language_version=21
+build --tool_java_runtime_version=remotejdk_21
 
 # We target java 11 by default
 
@@ -101,6 +105,7 @@ test --test_env=JRUBY_OPTS="--dev"
 
 test:windows --test_env=PATH
 test:windows --test_env=LOCALAPPDATA
+test:windows --test_env=PROCESSOR_ARCHITECTURE
 test:windows --test_env=PROGRAMFILES="C:\\Program Files"
 test:windows --test_env=PROGRAMFILES(X86)="C:\\Program Files (x86)"
 
@@ -114,9 +119,9 @@ build:release --stamp
 build:release --compilation_mode=opt
 
 # As regular `release` but all the build work happens on the RBE
-build:remote_release --config=release
-build:remote_release --config=remote
-build:remote_release --remote_download_toplevel
+build:rbe_release --config=release
+build:rbe_release --config=rbe
+build:rbe_release --remote_download_toplevel
 
 # RBE
 import %workspace%/.bazelrc.remote

.bazelrc.remote

@@ -1,68 +1,68 @@
 # The RBE to use
-build:remote --bes_results_url=https://gypsum.cluster.engflow.com/invocation
-build:remote --bes_backend=grpcs://gypsum.cluster.engflow.com
-build:remote --remote_executor=grpcs://gypsum.cluster.engflow.com
-build:remote --remote_cache=grpcs://gypsum.cluster.engflow.com
+build:rbe --bes_results_url=https://gypsum.cluster.engflow.com/invocation
+build:rbe --bes_backend=grpcs://gypsum.cluster.engflow.com
+build:rbe --remote_executor=grpcs://gypsum.cluster.engflow.com
+build:rbe --remote_cache=grpcs://gypsum.cluster.engflow.com
 
 # The number of cores available
-build:remote -j 50
+build:rbe -j 50
 
-build:remote --define=EXECUTOR=remote
-build:remote --experimental_inmemory_dotd_files
-build:remote --experimental_inmemory_jdeps_files
-build:remote --remote_timeout=3600
-build:remote --spawn_strategy=remote,local
-#build:remote --nolegacy_important_outputs
-build:remote --incompatible_strict_action_env=true
+build:rbe --define=EXECUTOR=remote
+build:rbe --experimental_inmemory_dotd_files
+build:rbe --experimental_inmemory_jdeps_files
+build:rbe --remote_timeout=3600
+build:rbe --spawn_strategy=remote,local
+#build:rbe --nolegacy_important_outputs
+build:rbe --incompatible_strict_action_env=true
 
-build:remote --crosstool_top=//common/remote-build/cc:toolchain
-build:remote --extra_execution_platforms=//common/remote-build:platform
-build:remote --extra_toolchains=//common/remote-build:cc-toolchain
-build:remote --host_platform=//common/remote-build:platform
-build:remote --platforms=//common/remote-build:platform
-build:remote --cxxopt=-std=c++14
+build:rbe --crosstool_top=//common/remote-build/cc:toolchain
+build:rbe --extra_execution_platforms=//common/remote-build:platform
+build:rbe --extra_toolchains=//common/remote-build:cc-toolchain
+build:rbe --host_platform=//common/remote-build:platform
+build:rbe --platforms=//common/remote-build:platform
+build:rbe --cxxopt=-std=c++14
 
 # The Docker images are running Linux
-build:remote --cpu=k8
-build:remote --host_cpu=k8
+build:rbe --cpu=k8
+build:rbe --host_cpu=k8
 
-build:remote --disk_cache=
+build:rbe --disk_cache=
 
-build:remote --incompatible_enable_cc_toolchain_resolution
-build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
-test:remote --test_env=DISPLAY=:99.0
-test:remote --test_tag_filters=-skip-remote,-remote
+build:rbe --incompatible_enable_cc_toolchain_resolution
+build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+test:rbe --test_env=DISPLAY=:99.0
+test:rbe --test_tag_filters=-skip-rbe,-remote
 
 # Env vars we can hard code
-build:remote --action_env=HOME=/home/dev
-build:remote --action_env=PATH=/bin:/usr/bin:/usr/local/bin
-test:remote --test_env=PATH=/bin:/usr/bin:/usr/local/bin
-test:remote --test_env=HOME=/home/dev
+build:rbe --action_env=HOME=/home/dev
+build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:rbe --test_env=HOME=/home/dev
 
 # Make sure we sniff credentials properly
-build:remote --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
+build:rbe --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
 
 # Use pinned browsers when running remotely
-build:remote --//common:pin_browsers
+build:rbe --//common:pin_browsers
 
 # The remote build machines are pretty small, and 50 threads may leave them
 # thrashing, but our dev machines are a lot larger. Scale the workload so we
 # make reasonable usage of everything, everywhere, all at once.
-build:remote --local_resources=cpu='HOST_CPUS*10'
-build:remote --local_resources=memory='HOST_RAM*4.0'
+build:rbe --local_resources=cpu='HOST_CPUS*10'
+build:rbe --local_resources=memory='HOST_RAM*4.0'
 
 # A small hint that we're running our tests remotely
-test:remote --test_env=REMOTE_BUILD=1
+test:rbe --test_env=REMOTE_BUILD=1
 
 # Wait for up to 5 minutes for a test to pass
-test:remote --test_timeout=600
+test:rbe --test_timeout=600
 
 # Extend the remote config for CI
-build:remote-ci --config=remote
-build:remote-ci --curses=no --color=yes --show_timestamps --show_progress_rate_limit=5
-build:remote-ci --bes_upload_mode=wait_for_upload_complete
-build:remote-ci --remote_download_minimal
+build:rbe-ci --config=rbe
+build:rbe-ci --curses=no --color=yes --show_timestamps --show_progress_rate_limit=5
+build:rbe-ci --bes_upload_mode=wait_for_upload_complete
+build:rbe-ci --remote_download_minimal
 
 # Configuration changes suggested by EngFlow
-build:remote --grpc_keepalive_time=30s
-build:remote --nolegacy_important_outputs
+build:rbe --grpc_keepalive_time=30s
+build:rbe --nolegacy_important_outputs

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -1,94 +1,128 @@
 name: 🐛 Bug Report
 description: File a bug report
 title: "[🐛 Bug]: "
-labels: [ I-defect, needs-triaging ]
+labels: [ I-defect, A-needs-triaging ]
 body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
   - type: textarea
-    id: what-happened
+    id: description
     attributes:
-      label: What happened?
-      description: |
-        Describe clearly and concisely the bug including instructions showing how to reproduce it.
+      label: Description
       placeholder: |
-        Please add as many details as possible to avoid assumptions from our side. How do you
-        trigger this bug? What did you expect to happen? Please walk us through it step by step.
-        Notes:
-        If the issue is with Google Chrome consider logging an issue with ChromeDriver instead:
-        https://bugs.chromium.org/p/chromedriver
-        If the issue is with Firefox GeckoDriver (aka Marionette) consider logging an issue with
-        Mozilla: https://bugzilla.mozilla.org/buglist.cgi?product=Testing&component=Marionette
-        If the issue is with Microsoft Edge consider logging an issue with Microsoft instead:
-        https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/
-        If the issue is with Safari, only Safari 10+ is supported. Please log any Safari issue
-        with Apple: https://bugreport.apple.com/
+        Include details like:
+        - What you were trying to do
+        - What you expected to happen
+        - What actually happened
+        - Any relevant context or configuration
+        - Stacktrace or error message if applicable
     validations:
       required: true
   - type: textarea
-    id: repro-command
+    id: reproduction
     attributes:
-      label: How can we reproduce the issue?
-      description: |
-        Share with a code snippet or a GitHub repo to reproduce the issue.
+      label: Reproducible Code
       placeholder: |
-        Please share the code script to reproduce the issue. If more than one file is needed,
-        create a GitHub repository and share the link.
-        This will be automatically formatted into code, so no need for backticks.
-        Be sure to include an SSCCE (Short, Self Contained, Correct
-        [compilable] example) http://sscce.org/
-        Issues without a reproduction script are likely to stall and eventually be closed.
+        (This section renders as code, no need for backticks)
+
+        * We can't fix an issue we can't reproduce.
+        * If more than one file is needed, create a new GitHub repository and link it here.
+        * Reproduction should be SSCCE: Short, Self Contained, Correct (Compilable), Example.
       render: shell
     validations:
       required: true
   - type: textarea
     id: logs
     attributes:
-      label: Relevant log output
-      description: |
-        Please copy and paste any relevant log output.
-        Ideally, turn on more detailed logging: https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/
-        This will be automatically formatted, so no need for backticks.
-      render: shell
-    validations:
-      required: true
+      label: Debugging Logs
+      placeholder: |
+        Note: the stack trace should be in the explanation section above
+        Instructions for enabling and referencing logs can be found in the links below
+      render: logs
+  - type: markdown
+    id: link
+    attributes:
+      value: |
+        **Read our [logging documentation](https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/)**
+        **Link to a [gist](https://gist.github.com/) if logs are too long**
+         
+
+        ## Help us Address Your Issue Faster!
   - type: input
-    id: operating-system
+    id: selenium-version
     attributes:
-      label: Operating System
-      description: What host operating system are you using to run Selenium?
-      placeholder: Windows 10? macOS BigSur? Ubuntu?
+      label: What version of Selenium are you currently using?
+      description: Important! The latest released version of Selenium is 4.32 and we can't fix old versions.
+      placeholder: e.g., 4.17.0
     validations:
       required: true
-  - type: input
-    id: selenium-version
+  - type: checkboxes
+    id: prerequisites
+    attributes:
+      label: The following statements are true
+      options:
+        - label: This applies to the most recent version of Selenium (we can't fix old versions)
+          required: true
+        - label: This hasn't already been reported (I searched and didn't find it)
+          required: true
+        - label: All information necessary to reproduce the issue has been provided above
+          required: true
+  - type: dropdown
+    id: regression
     attributes:
-      label: Selenium version
-      description: What programming language release version of Selenium?
-      placeholder: Java 4.0.0? Ruby 4.0.3? (please use the full version number).
+      label: Did this work for you before?
+      options:
+        - Not sure, this is my first time trying it
+        - Yes this is a regression
     validations:
       required: true
   - type: input
-    id: browser-versions
+    id: last-good
+    attributes:
+      label: If yes, what version of Selenium did it work with?
+      placeholder: "e.g., 4.8.0"
+    validations:
+      required: false
+  - type: dropdown
+    id: operating-system
     attributes:
-      label: What are the browser(s) and version(s) where you see this issue?
-      description: What browser and versions are you using?
-      placeholder: Example - Chrome 90, Firefox 88, etc.
+      label: Operating System
+      options:
+        - "--"
+        - Windows
+        - macOS
+        - Linux (specify in the description)
     validations:
       required: true
-  - type: input
-    id: browser-driver-versions
+  - type: dropdown
+    id: bindings
     attributes:
-      label: What are the browser driver(s) and version(s) where you see this issue?
-      description: What browser driver(s) are you using?
-      placeholder: Example - ChromeDriver 94.0.4606.61, GeckoDriver 0.30.0, etc.
+      label: Selenium Language Binding
+      options:
+        - "--"
+        - Java
+        - Python
+        - C#/.NET
+        - JavaScript/Node.js
+        - Ruby
     validations:
       required: true
-  - type: input
-    id: selenium-grid-version
+  - type: dropdown
+    id: browsers
+    attributes:
+      label: Which browsers are you experiencing the issue with?
+      multiple: true
+      options:
+        - Chrome
+        - Firefox
+        - Edge
+        - Safari
+        - IE
+        - Other (please specify in the description)
+  - type: dropdown
+    id: grid
     attributes:
       label: Are you using Selenium Grid?
-      description: What version of Selenium Grid are you using?
-      placeholder: Example - 4.0.0
+      options:
+        - "No"
+        - "Yes"
+    validations:
+      required: true