Dispose of JsonDocument

RenderMichael · RenderMichael · commit d501714d8359 · 2024-11-13T23:48:03.000-05:00
diff --git a/dotnet/src/webdriver/Firefox/FirefoxProfile.cs b/dotnet/src/webdriver/Firefox/FirefoxProfile.cs
@@ -298,7 +298,7 @@ private void ReadDefaultPreferences()
         {
             using (Stream defaultPrefsStream = ResourceUtilities.GetResourceStream("webdriver_prefs.json", "webdriver_prefs.json"))
             {
-                JsonDocument defaultPreferences = JsonDocument.Parse(defaultPrefsStream);
+                using JsonDocument defaultPreferences = JsonDocument.Parse(defaultPrefsStream);
 
                 JsonElement immutableDefaultPreferences = defaultPreferences.RootElement.GetProperty("frozen");
                 JsonElement editableDefaultPreferences = defaultPreferences.RootElement.GetProperty("mutable");

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ private void ReadDefaultPreferences()`
`298`	`298`	`{`
`299`	`299`	`using (Stream defaultPrefsStream = ResourceUtilities.GetResourceStream("webdriver_prefs.json", "webdriver_prefs.json"))`
`300`	`300`	`{`
`301`		`- JsonDocument defaultPreferences = JsonDocument.Parse(defaultPrefsStream);`
	`301`	`+ using JsonDocument defaultPreferences = JsonDocument.Parse(defaultPrefsStream);`
`302`	`302`
`303`	`303`	`JsonElement immutableDefaultPreferences = defaultPreferences.RootElement.GetProperty("frozen");`
`304`	`304`	`JsonElement editableDefaultPreferences = defaultPreferences.RootElement.GetProperty("mutable");`