Skip to content

Commit d65bad2

Browse files
committed
Refactoring: moving an auxiliary class from the top level to inner class
1 parent 953007b commit d65bad2

File tree

1 file changed

+46
-47
lines changed

1 file changed

+46
-47
lines changed

java/server/src/org/openqa/selenium/remote/server/log/SessionLogsToFileRepository.java

Lines changed: 46 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -32,53 +32,6 @@
3232
import java.util.Map;
3333
import java.util.logging.LogRecord;
3434

35-
class LogFile {
36-
private String logName;
37-
private ObjectOutputStream logWriter;
38-
private ObjectInputStream logReader;
39-
40-
public LogFile(String logName) {
41-
this.logName = logName;
42-
}
43-
44-
public void openLogWriter() throws IOException {
45-
logWriter = new ObjectOutputStream(new FileOutputStream(logName));
46-
}
47-
48-
public void closeLogWriter() throws IOException {
49-
if (logWriter != null) {
50-
logWriter.close();
51-
}
52-
}
53-
54-
public void openLogReader() throws IOException {
55-
logReader = new ObjectInputStream(new FileInputStream(logName));
56-
}
57-
58-
public void closeLogReader() throws IOException {
59-
if (logReader != null) {
60-
logReader.close();
61-
}
62-
}
63-
64-
public ObjectOutputStream getLogWriter() {
65-
return logWriter;
66-
}
67-
68-
public ObjectInputStream getLogReader() {
69-
return logReader;
70-
}
71-
72-
public void removeLogFile() throws IOException {
73-
if (logName != null) {
74-
closeLogReader();
75-
closeLogWriter();
76-
new File(logName).delete();
77-
}
78-
}
79-
}
80-
81-
8235
public class SessionLogsToFileRepository {
8336
private Map<SessionId, LogFile> sessionToLogFileMap;
8437

@@ -173,4 +126,50 @@ public void removeLogFile(SessionId sessionId) {
173126
throw new RuntimeException(e);
174127
}
175128
}
129+
130+
static class LogFile {
131+
private String logName;
132+
private ObjectOutputStream logWriter;
133+
private ObjectInputStream logReader;
134+
135+
public LogFile(String logName) {
136+
this.logName = logName;
137+
}
138+
139+
public void openLogWriter() throws IOException {
140+
logWriter = new ObjectOutputStream(new FileOutputStream(logName));
141+
}
142+
143+
public void closeLogWriter() throws IOException {
144+
if (logWriter != null) {
145+
logWriter.close();
146+
}
147+
}
148+
149+
public void openLogReader() throws IOException {
150+
logReader = new ObjectInputStream(new FileInputStream(logName));
151+
}
152+
153+
public void closeLogReader() throws IOException {
154+
if (logReader != null) {
155+
logReader.close();
156+
}
157+
}
158+
159+
public ObjectOutputStream getLogWriter() {
160+
return logWriter;
161+
}
162+
163+
public ObjectInputStream getLogReader() {
164+
return logReader;
165+
}
166+
167+
public void removeLogFile() throws IOException {
168+
if (logName != null) {
169+
closeLogReader();
170+
closeLogWriter();
171+
new File(logName).delete();
172+
}
173+
}
174+
}
176175
}

0 commit comments

Comments
 (0)