Merge branch 'trunk' into escape_cookie_value

Author: Delta456

.gitignore

@@ -140,3 +140,4 @@ javascript/node/selenium-webdriver/.vscode/settings.json
 
 dotnet-bin
 .metadata/
+.npmrc

javascript/node/selenium-webdriver/BUILD.bazel

@@ -11,7 +11,7 @@ load("//javascript/private:browsers.bzl", "BROWSERS")
 
 npm_link_all_packages(name = "node_modules")
 
-VERSION = "4.25.0-nightly202408281539"
+VERSION = "4.25.0-nightly202409161624"
 
 BROWSER_VERSIONS = [
     "v85",

javascript/node/selenium-webdriver/CHANGES.md

@@ -1,3 +1,7 @@
+## 4.24.1
+
+-  Close CDP websocket connection on driver.quit (#14501)
+
 ## 4.24.0
 
 - [js] expose selenium version for node.js (#14325)

javascript/node/selenium-webdriver/lib/webdriver.js

@@ -784,6 +784,14 @@ class WebDriver {
       if (this.onQuit_) {
         return this.onQuit_.call(void 0)
       }
+
+      // Close the websocket connection on quit
+      // If the websocket connection is not closed,
+      // and we are running CDP sessions against the Selenium Grid,
+      // the node process never exits since the websocket connection is open until the Grid is shutdown.
+      if (this._wsConnection !== undefined) {
+        this._wsConnection.close()
+      }
     })
   }
 

javascript/node/selenium-webdriver/package.json

@@ -1,6 +1,6 @@
 {
   "name": "selenium-webdriver",
-  "version": "4.25.0-nightly202408281539",
+  "version": "4.25.0-nightly202409161624",
   "description": "The official WebDriver JavaScript bindings from the Selenium project",
   "license": "Apache-2.0",
   "keywords": [