Mark all known enums with appropriate converter

nvborisenko · nvborisenko · commit da108b3eb15a · 2025-10-05T21:18:47.000+03:00
diff --git a/dotnet/src/webdriver/BiDi/Browser/ClientWindowInfo.cs b/dotnet/src/webdriver/BiDi/Browser/ClientWindowInfo.cs
@@ -17,10 +17,14 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Browser;
 
 public sealed record ClientWindowInfo(bool Active, ClientWindow ClientWindow, ClientWindowState State, int Height, int Width, int X, int Y);
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ClientWindowState>))]
 public enum ClientWindowState
 {
     Fullscreen,
diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/CaptureScreenshotCommand.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/CaptureScreenshotCommand.cs
@@ -18,6 +18,7 @@
 // </copyright>
 
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Text.Json.Serialization;
 
@@ -37,6 +38,7 @@ public sealed class CaptureScreenshotOptions : CommandOptions
     public ClipRectangle? Clip { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ScreenshotOrigin>))]
 public enum ScreenshotOrigin
 {
     Viewport,
diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/CreateCommand.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/CreateCommand.cs
@@ -18,6 +18,8 @@
 // </copyright>
 
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.BrowsingContext;
 
@@ -35,6 +37,7 @@ public sealed class CreateOptions : CommandOptions
     public Browser.UserContext? UserContext { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ContextType>))]
 public enum ContextType
 {
     Tab,
diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/Locator.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/Locator.cs
@@ -17,6 +17,7 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.BrowsingContext;
@@ -54,6 +55,7 @@ public sealed record AccessibilityValue
 
 public sealed record ContextValue(BrowsingContext Context);
 
+[JsonConverter(typeof(CamelCaseEnumConverter<MatchType>))]
 public enum MatchType
 {
     Full,
diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/PrintCommand.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/PrintCommand.cs
@@ -18,8 +18,10 @@
 // </copyright>
 
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Collections.Generic;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.BrowsingContext;
 
@@ -56,6 +58,7 @@ public struct PrintMargin
     public double? Top { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<PrintOrientation>))]
 public enum PrintOrientation
 {
     Portrait,
diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/UserPromptOpenedEventArgs.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/UserPromptOpenedEventArgs.cs
@@ -17,6 +17,7 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.BrowsingContext;
@@ -28,6 +29,7 @@ public sealed record UserPromptOpenedEventArgs(BiDi BiDi, BrowsingContext Contex
     public string? DefaultValue { get; internal set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<UserPromptType>))]
 public enum UserPromptType
 {
     Alert,
diff --git a/dotnet/src/webdriver/BiDi/Communication/Broker.cs b/dotnet/src/webdriver/BiDi/Communication/Broker.cs
@@ -83,8 +83,6 @@ internal Broker(BiDi bidi, Uri url)
                 new InternalIdConverter(_bidi),
                 new PreloadScriptConverter(_bidi),
                 new RealmConverter(_bidi),
-                new RealmTypeConverter(),
-                new ScreenOrientationTypeConverter(),
                 new DateTimeOffsetConverter(),
                 new PrintPageRangeConverter(),
                 new InputOriginConverter(),
diff --git a/dotnet/src/webdriver/BiDi/Emulation/SetForcedColorsModeThemeOverrideCommand.cs b/dotnet/src/webdriver/BiDi/Emulation/SetForcedColorsModeThemeOverrideCommand.cs
@@ -17,9 +17,10 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System.Collections.Generic;
 using System.Text.Json.Serialization;
-using OpenQA.Selenium.BiDi.Communication;
 
 namespace OpenQA.Selenium.BiDi.Emulation;
 
@@ -35,6 +36,7 @@ public sealed class SetForcedColorsModeThemeOverrideOptions : CommandOptions
     public IEnumerable<Browser.UserContext>? UserContexts { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ForcedColorsModeTheme>))]
 public enum ForcedColorsModeTheme
 {
     Light,
diff --git a/dotnet/src/webdriver/BiDi/Emulation/SetScreenOrientationOverrideCommand.cs b/dotnet/src/webdriver/BiDi/Emulation/SetScreenOrientationOverrideCommand.cs
@@ -17,9 +17,10 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System.Collections.Generic;
 using System.Text.Json.Serialization;
-using OpenQA.Selenium.BiDi.Communication;
 
 namespace OpenQA.Selenium.BiDi.Emulation;
 
@@ -35,12 +36,14 @@ public sealed class SetScreenOrientationOverrideOptions : CommandOptions
     public IEnumerable<Browser.UserContext>? UserContexts { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ScreenOrientationNatural>))]
 public enum ScreenOrientationNatural
 {
     Portrait,
     Landscape
 }
 
+[JsonConverter(typeof(ScreenOrientationTypeConverter))]
 public enum ScreenOrientationType
 {
     PortraitPrimary,
diff --git a/dotnet/src/webdriver/BiDi/Input/SourceActions.cs b/dotnet/src/webdriver/BiDi/Input/SourceActions.cs
@@ -17,6 +17,7 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Collections;
 using System.Collections.Generic;
@@ -144,6 +145,7 @@ public sealed record PointerParameters
     public PointerType? PointerType { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<PointerType>))]
 public enum PointerType
 {
     Mouse,
diff --git a/dotnet/src/webdriver/BiDi/Log/LogEntry.cs b/dotnet/src/webdriver/BiDi/Log/LogEntry.cs
@@ -17,8 +17,10 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Collections.Generic;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.Log;
 
@@ -42,6 +44,7 @@ public sealed record ConsoleLogEntry(BiDi BiDi, Level Level, Script.Source Sourc
 public sealed record JavascriptLogEntry(BiDi BiDi, Level Level, Script.Source Source, string? Text, DateTimeOffset Timestamp)
     : LogEntry(BiDi, Level, Source, Text, Timestamp);
 
+[JsonConverter(typeof(CamelCaseEnumConverter<Level>))]
 public enum Level
 {
     Debug,
diff --git a/dotnet/src/webdriver/BiDi/Network/AddDataCollectorCommand.cs b/dotnet/src/webdriver/BiDi/Network/AddDataCollectorCommand.cs
@@ -17,8 +17,10 @@
 // under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.Network;
 
@@ -38,11 +40,13 @@ public class AddDataCollectorOptions : CommandOptions
 
 public sealed record AddDataCollectorResult(Collector Collector) : EmptyResult;
 
+[JsonConverter(typeof(CamelCaseEnumConverter<DataType>))]
 public enum DataType
 {
     Response
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<CollectorType>))]
 public enum CollectorType
 {
     Blob
diff --git a/dotnet/src/webdriver/BiDi/Network/AddInterceptCommand.cs b/dotnet/src/webdriver/BiDi/Network/AddInterceptCommand.cs
@@ -17,8 +17,10 @@
 // under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.Network;
 
@@ -48,6 +50,7 @@ public record BrowsingContextAddInterceptOptions
 
 public sealed record AddInterceptResult(Intercept Intercept) : EmptyResult;
 
+[JsonConverter(typeof(CamelCaseEnumConverter<InterceptPhase>))]
 public enum InterceptPhase
 {
     BeforeRequestSent,
diff --git a/dotnet/src/webdriver/BiDi/Network/Cookie.cs b/dotnet/src/webdriver/BiDi/Network/Cookie.cs
@@ -25,6 +25,7 @@ namespace OpenQA.Selenium.BiDi.Network;
 
 public sealed record Cookie(string Name, BytesValue Value, string Domain, string Path, long Size, bool HttpOnly, bool Secure, SameSite SameSite, [property: JsonConverter(typeof(DateTimeOffsetSecondsConverter))] DateTimeOffset? Expiry);
 
+[JsonConverter(typeof(CamelCaseEnumConverter<SameSite>))]
 public enum SameSite
 {
     Strict,
diff --git a/dotnet/src/webdriver/BiDi/Network/Initiator.cs b/dotnet/src/webdriver/BiDi/Network/Initiator.cs
@@ -17,6 +17,9 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Network;
 
 public sealed record Initiator(InitiatorType Type)
@@ -30,6 +33,7 @@ public sealed record Initiator(InitiatorType Type)
     public Request? Request { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<InitiatorType>))]
 public enum InitiatorType
 {
     Parser,
diff --git a/dotnet/src/webdriver/BiDi/Network/SetCacheBehaviorCommand.cs b/dotnet/src/webdriver/BiDi/Network/SetCacheBehaviorCommand.cs
@@ -17,8 +17,10 @@
 // under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.Network;
 
@@ -44,6 +46,7 @@ internal SetCacheBehaviorOptions(BrowsingContextSetCacheBehaviorOptions? options
 
 public sealed record BrowsingContextSetCacheBehaviorOptions;
 
+[JsonConverter(typeof(CamelCaseEnumConverter<CacheBehavior>))]
 public enum CacheBehavior
 {
     Default,
diff --git a/dotnet/src/webdriver/BiDi/Script/RealmType.cs b/dotnet/src/webdriver/BiDi/Script/RealmType.cs
@@ -17,8 +17,12 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Script;
 
+[JsonConverter(typeof(RealmTypeConverter))]
 public enum RealmType
 {
     Window,
diff --git a/dotnet/src/webdriver/BiDi/Script/RemoteValue.cs b/dotnet/src/webdriver/BiDi/Script/RemoteValue.cs
@@ -17,6 +17,7 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Collections.Generic;
 using System.Numerics;
@@ -269,6 +270,7 @@ public sealed record WindowProxyRemoteValue(WindowProxyProperties Value) : Remot
     public InternalId? InternalId { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<Mode>))]
 public enum Mode
 {
     Open,
diff --git a/dotnet/src/webdriver/BiDi/Script/ResultOwnership.cs b/dotnet/src/webdriver/BiDi/Script/ResultOwnership.cs
@@ -17,8 +17,12 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Script;
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ResultOwnership>))]
 public enum ResultOwnership
 {
     Root,
diff --git a/dotnet/src/webdriver/BiDi/Script/SerializationOptions.cs b/dotnet/src/webdriver/BiDi/Script/SerializationOptions.cs
@@ -17,6 +17,9 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Script;
 
 public sealed class SerializationOptions
@@ -28,6 +31,7 @@ public sealed class SerializationOptions
     public ShadowTree? IncludeShadowTree { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<ShadowTree>))]
 public enum ShadowTree
 {
     None,
diff --git a/dotnet/src/webdriver/BiDi/Session/UserPromptHandler.cs b/dotnet/src/webdriver/BiDi/Session/UserPromptHandler.cs
@@ -17,6 +17,9 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
+using System.Text.Json.Serialization;
+
 namespace OpenQA.Selenium.BiDi.Session;
 
 public sealed record UserPromptHandler
@@ -34,6 +37,7 @@ public sealed record UserPromptHandler
     public UserPromptHandlerType? Prompt { get; set; }
 }
 
+[JsonConverter(typeof(CamelCaseEnumConverter<UserPromptHandlerType>))]
 public enum UserPromptHandlerType
 {
     Accept,

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`// </copyright>`
`19`	`19`
`20`	`20`	`using OpenQA.Selenium.BiDi.Communication;`
	`21`	`+using OpenQA.Selenium.BiDi.Communication.Json.Converters;`
`21`	`22`	`using System;`
`22`	`23`	`using System.Text.Json.Serialization;`
`23`	`24`
`@@ -37,6 +38,7 @@ public sealed class CaptureScreenshotOptions : CommandOptions`
`37`	`38`	`public ClipRectangle? Clip { get; set; }`
`38`	`39`	`}`
`39`	`40`
	`41`	`+[JsonConverter(typeof(CamelCaseEnumConverter<ScreenshotOrigin>))]`
`40`	`42`	`public enum ScreenshotOrigin`
`41`	`43`	`{`
`42`	`44`	`Viewport,`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@`
`18`	`18`	`// </copyright>`
`19`	`19`
`20`	`20`	`using OpenQA.Selenium.BiDi.Communication;`
	`21`	`+using OpenQA.Selenium.BiDi.Communication.Json.Converters;`
	`22`	`+using System.Text.Json.Serialization;`
`21`	`23`
`22`	`24`	`namespace OpenQA.Selenium.BiDi.BrowsingContext;`
`23`	`25`
`@@ -35,6 +37,7 @@ public sealed class CreateOptions : CommandOptions`
`35`	`37`	`public Browser.UserContext? UserContext { get; set; }`
`36`	`38`	`}`
`37`	`39`
	`40`	`+[JsonConverter(typeof(CamelCaseEnumConverter<ContextType>))]`
`38`	`41`	`public enum ContextType`
`39`	`42`	`{`
`40`	`43`	`Tab,`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,10 @@`
`18`	`18`	`// </copyright>`
`19`	`19`
`20`	`20`	`using OpenQA.Selenium.BiDi.Communication;`
	`21`	`+using OpenQA.Selenium.BiDi.Communication.Json.Converters;`
`21`	`22`	`using System;`
`22`	`23`	`using System.Collections.Generic;`
	`24`	`+using System.Text.Json.Serialization;`
`23`	`25`
`24`	`26`	`namespace OpenQA.Selenium.BiDi.BrowsingContext;`
`25`	`27`
`@@ -56,6 +58,7 @@ public struct PrintMargin`
`56`	`58`	`public double? Top { get; set; }`
`57`	`59`	`}`
`58`	`60`
	`61`	`+[JsonConverter(typeof(CamelCaseEnumConverter<PrintOrientation>))]`
`59`	`62`	`public enum PrintOrientation`
`60`	`63`	`{`
`61`	`64`	`Portrait,`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`// under the License.`
`18`	`18`	`// </copyright>`
`19`	`19`
	`20`	`+using OpenQA.Selenium.BiDi.Communication.Json.Converters;`
`20`	`21`	`using System.Text.Json.Serialization;`
`21`	`22`
`22`	`23`	`namespace OpenQA.Selenium.BiDi.BrowsingContext;`
`@@ -28,6 +29,7 @@ public sealed record UserPromptOpenedEventArgs(BiDi BiDi, BrowsingContext Contex`
`28`	`29`	`public string? DefaultValue { get; internal set; }`
`29`	`30`	`}`
`30`	`31`
	`32`	`+[JsonConverter(typeof(CamelCaseEnumConverter<UserPromptType>))]`
`31`	`33`	`public enum UserPromptType`
`32`	`34`	`{`
`33`	`35`	`Alert,`
Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,10 @@`
`17`	`17`	`// under the License.`
`18`	`18`	`// </copyright>`
`19`	`19`
	`20`	`+using OpenQA.Selenium.BiDi.Communication;`
	`21`	`+using OpenQA.Selenium.BiDi.Communication.Json.Converters;`
`20`	`22`	`using System.Collections.Generic;`
`21`	`23`	`using System.Text.Json.Serialization;`
`22`		`-using OpenQA.Selenium.BiDi.Communication;`
`23`	`24`
`24`	`25`	`namespace OpenQA.Selenium.BiDi.Emulation;`
`25`	`26`
`@@ -35,12 +36,14 @@ public sealed class SetScreenOrientationOverrideOptions : CommandOptions`
`35`	`36`	`public IEnumerable<Browser.UserContext>? UserContexts { get; set; }`
`36`	`37`	`}`
`37`	`38`
	`39`	`+[JsonConverter(typeof(CamelCaseEnumConverter<ScreenOrientationNatural>))]`
`38`	`40`	`public enum ScreenOrientationNatural`
`39`	`41`	`{`
`40`	`42`	`Portrait,`
`41`	`43`	`Landscape`
`42`	`44`	`}`
`43`	`45`
	`46`	`+[JsonConverter(typeof(ScreenOrientationTypeConverter))]`
`44`	`47`	`public enum ScreenOrientationType`
`45`	`48`	`{`
`46`	`49`	`PortraitPrimary,`