Skip to content

Commit da5e14d

Browse files
fixing teardown
1 parent 71c35f8 commit da5e14d

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

py/conftest.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -186,24 +186,15 @@ def service(self):
186186
@property
187187
def driver(self):
188188
if not self._driver:
189-
return self._initialize_driver()
189+
self._driver = self._initialize_driver()
190190
return self._driver
191191

192192
def _initialize_driver(self):
193193
if self.options:
194194
self.kwargs["options"] = self.options
195195
if self.driver_path:
196196
self.kwargs["service"] = self.service
197-
self._driver = getattr(webdriver, self._driver_class)(**self.kwargs)
198-
return self._driver
199-
200-
@property
201-
def stop_driver(self):
202-
def fin():
203-
if self._driver is not None:
204-
self._driver.quit()
205-
206-
return fin
197+
return getattr(webdriver, self._driver_class)(**self.kwargs)
207198

208199

209200
@pytest.fixture(scope="function")
@@ -232,12 +223,12 @@ def driver(request):
232223
marker.kwargs.pop("raises")
233224
pytest.xfail(**marker.kwargs)
234225

235-
request.addfinalizer(selenium_driver.stop_driver)
236-
237226
driver_instance = selenium_driver.driver
238227

239228
yield driver_instance
240229

230+
driver_instance.quit()
231+
241232

242233
@pytest.fixture(scope="session", autouse=True)
243234
def stop_driver(request):

0 commit comments

Comments
 (0)