Skip to content

Commit de2075f

Browse files
committed
Simplified required properties dto
1 parent eb0ac57 commit de2075f

File tree

5 files changed

+6
-28
lines changed

5 files changed

+6
-28
lines changed

dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,7 @@ public abstract record ClipRectangle
4343
{
4444
public record Box(double X, double Y, double Width, double Height) : ClipRectangle;
4545

46-
public record Element(Script.SharedReference SharedReference) : ClipRectangle
47-
{
48-
[JsonPropertyName("element")]
49-
public Script.SharedReference SharedReference { get; } = SharedReference;
50-
}
46+
public record Element([property: JsonPropertyName("element")] Script.SharedReference SharedReference) : ClipRectangle;
5147
}
5248

5349
public record CaptureScreenshotResult(string Data)

dotnet/src/webdriver/BiDi/Modules/Input/Origin.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,8 @@ public record Viewport() : Origin;
1010

1111
public record Pointer() : Origin;
1212

13-
public record Element(Script.SharedReference SharedReference) : Origin
13+
public record Element([property: JsonPropertyName("element")] Script.SharedReference SharedReference) : Origin
1414
{
1515
public string Type { get; } = "element";
16-
17-
[JsonPropertyName("element")]
18-
public Script.SharedReference SharedReference { get; } = SharedReference;
1916
}
2017
}

dotnet/src/webdriver/BiDi/Modules/Network/ContinueWithAuthCommand.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@ internal class ContinueWithAuthCommand(ContinueWithAuthParameters @params) : Com
1313
[JsonDerivedType(typeof(Cancel), "cancel")]
1414
internal abstract record ContinueWithAuthParameters(Request Request) : CommandParameters
1515
{
16-
internal record Credentials(Request Request, AuthCredentials AuthCredentials) : ContinueWithAuthParameters(Request)
17-
{
18-
[JsonPropertyName("credentials")]
19-
public AuthCredentials AuthCredentials { get; } = AuthCredentials;
20-
}
16+
internal record Credentials(Request Request, [property: JsonPropertyName("credentials")] AuthCredentials AuthCredentials) : ContinueWithAuthParameters(Request);
2117

2218
internal record Default(Request Request) : ContinueWithAuthParameters(Request);
2319

dotnet/src/webdriver/BiDi/Modules/Script/Target.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,10 @@ namespace OpenQA.Selenium.BiDi.Modules.Script;
88
[JsonDerivedType(typeof(Context))]
99
public abstract record Target
1010
{
11-
public record Realm(Script.Realm Target) : Target
12-
{
13-
[JsonPropertyName("realm")]
14-
public Script.Realm Target { get; } = Target;
15-
}
11+
public record Realm([property: JsonPropertyName("realm")] Script.Realm Target) : Target;
1612

17-
public record Context(BrowsingContext.BrowsingContext Target) : Target
13+
public record Context([property: JsonPropertyName("context")] BrowsingContext.BrowsingContext Target) : Target
1814
{
19-
[JsonPropertyName("context")]
20-
public BrowsingContext.BrowsingContext Target { get; } = Target;
21-
2215
public string? Sandbox { get; set; }
2316
}
2417
}

dotnet/src/webdriver/BiDi/Modules/Storage/GetCookiesCommand.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@ public class CookieFilter
7171
[JsonDerivedType(typeof(StorageKey), "storageKey")]
7272
public abstract record PartitionDescriptor
7373
{
74-
public record Context(BrowsingContext.BrowsingContext Descriptor) : PartitionDescriptor
75-
{
76-
[JsonPropertyName("context")]
77-
public BrowsingContext.BrowsingContext Descriptor { get; } = Descriptor;
78-
}
74+
public record Context([property: JsonPropertyName("context")] BrowsingContext.BrowsingContext Descriptor) : PartitionDescriptor;
7975

8076
public record StorageKey : PartitionDescriptor
8177
{

0 commit comments

Comments
 (0)