Skip to content

Commit dffa806

Browse files
committed
Merge remote-tracking branch 'origin/trunk' into migrate-caffeine
Signed-off-by: Viet Nguyen Duc <[email protected]> # Conflicts: # MODULE.bazel # java/maven_install.json # rust/Cargo.Bazel.lock
2 parents 2c99100 + 7a60563 commit dffa806

File tree

653 files changed

+51405
-49035
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

653 files changed

+51405
-49035
lines changed

.bazelrc.remote

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ build:rbe --disk_cache=
3131
build:rbe --incompatible_enable_cc_toolchain_resolution
3232
build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
3333
test:rbe --test_env=DISPLAY=:99.0
34-
test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
34+
test:rbe --test_tag_filters=-skip-rbe,-remote
3535

3636
# Env vars we can hard code
3737
build:rbe --action_env=HOME=/home/dev
Lines changed: 94 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,94 +1,128 @@
11
name: 🐛 Bug Report
22
description: File a bug report
33
title: "[🐛 Bug]: "
4-
labels: [ I-defect, needs-triaging ]
4+
labels: [ I-defect, A-needs-triaging ]
55
body:
6-
- type: markdown
7-
attributes:
8-
value: |
9-
Thanks for taking the time to fill out this bug report!
106
- type: textarea
11-
id: what-happened
7+
id: description
128
attributes:
13-
label: What happened?
14-
description: |
15-
Describe clearly and concisely the bug including instructions showing how to reproduce it.
9+
label: Description
1610
placeholder: |
17-
Please add as many details as possible to avoid assumptions from our side. How do you
18-
trigger this bug? What did you expect to happen? Please walk us through it step by step.
19-
Notes:
20-
If the issue is with Google Chrome consider logging an issue with ChromeDriver instead:
21-
https://bugs.chromium.org/p/chromedriver
22-
If the issue is with Firefox GeckoDriver (aka Marionette) consider logging an issue with
23-
Mozilla: https://bugzilla.mozilla.org/buglist.cgi?product=Testing&component=Marionette
24-
If the issue is with Microsoft Edge consider logging an issue with Microsoft instead:
25-
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/
26-
If the issue is with Safari, only Safari 10+ is supported. Please log any Safari issue
27-
with Apple: https://bugreport.apple.com/
11+
Include details like:
12+
- What you were trying to do
13+
- What you expected to happen
14+
- What actually happened
15+
- Any relevant context or configuration
16+
- Stacktrace or error message if applicable
2817
validations:
2918
required: true
3019
- type: textarea
31-
id: repro-command
20+
id: reproduction
3221
attributes:
33-
label: How can we reproduce the issue?
34-
description: |
35-
Share with a code snippet or a GitHub repo to reproduce the issue.
22+
label: Reproducible Code
3623
placeholder: |
37-
Please share the code script to reproduce the issue. If more than one file is needed,
38-
create a GitHub repository and share the link.
39-
This will be automatically formatted into code, so no need for backticks.
40-
Be sure to include an SSCCE (Short, Self Contained, Correct
41-
[compilable] example) http://sscce.org/
42-
Issues without a reproduction script are likely to stall and eventually be closed.
24+
(This section renders as code, no need for backticks)
25+
26+
* We can't fix an issue we can't reproduce.
27+
* If more than one file is needed, create a new GitHub repository and link it here.
28+
* Reproduction should be SSCCE: Short, Self Contained, Correct (Compilable), Example.
4329
render: shell
4430
validations:
4531
required: true
4632
- type: textarea
4733
id: logs
4834
attributes:
49-
label: Relevant log output
50-
description: |
51-
Please copy and paste any relevant log output.
52-
Ideally, turn on more detailed logging: https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/
53-
This will be automatically formatted, so no need for backticks.
54-
render: shell
55-
validations:
56-
required: true
35+
label: Debugging Logs
36+
placeholder: |
37+
Note: the stack trace should be in the explanation section above
38+
Instructions for enabling and referencing logs can be found in the links below
39+
render: logs
40+
- type: markdown
41+
id: link
42+
attributes:
43+
value: |
44+
**Read our [logging documentation](https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/)**
45+
**Link to a [gist](https://gist.github.com/) if logs are too long**
46+
&nbsp;
47+
48+
## Help us Address Your Issue Faster!
5749
- type: input
58-
id: operating-system
50+
id: selenium-version
5951
attributes:
60-
label: Operating System
61-
description: What host operating system are you using to run Selenium?
62-
placeholder: Windows 10? macOS BigSur? Ubuntu?
52+
label: What version of Selenium are you currently using?
53+
description: Important! The latest released version of Selenium is 4.31 and we can't fix old versions.
54+
placeholder: e.g., 4.17.0
6355
validations:
6456
required: true
65-
- type: input
66-
id: selenium-version
57+
- type: checkboxes
58+
id: prerequisites
59+
attributes:
60+
label: The following statements are true
61+
options:
62+
- label: This applies to the most recent version of Selenium (we can't fix old versions)
63+
required: true
64+
- label: This hasn't already been reported (I searched and didn't find it)
65+
required: true
66+
- label: All information necessary to reproduce the issue has been provided above
67+
required: true
68+
- type: dropdown
69+
id: regression
6770
attributes:
68-
label: Selenium version
69-
description: What programming language release version of Selenium?
70-
placeholder: Java 4.0.0? Ruby 4.0.3? (please use the full version number).
71+
label: Did this work for you before?
72+
options:
73+
- Not sure, this is my first time trying it
74+
- Yes this is a regression
7175
validations:
7276
required: true
7377
- type: input
74-
id: browser-versions
78+
id: last-good
79+
attributes:
80+
label: If yes, what version of Selenium did it work with?
81+
placeholder: "e.g., 4.8.0"
82+
validations:
83+
required: false
84+
- type: dropdown
85+
id: operating-system
7586
attributes:
76-
label: What are the browser(s) and version(s) where you see this issue?
77-
description: What browser and versions are you using?
78-
placeholder: Example - Chrome 90, Firefox 88, etc.
87+
label: Operating System
88+
options:
89+
- "--"
90+
- Windows
91+
- macOS
92+
- Linux (specify in the description)
7993
validations:
8094
required: true
81-
- type: input
82-
id: browser-driver-versions
95+
- type: dropdown
96+
id: bindings
8397
attributes:
84-
label: What are the browser driver(s) and version(s) where you see this issue?
85-
description: What browser driver(s) are you using?
86-
placeholder: Example - ChromeDriver 94.0.4606.61, GeckoDriver 0.30.0, etc.
98+
label: Selenium Language Binding
99+
options:
100+
- "--"
101+
- Java
102+
- Python
103+
- C#/.NET
104+
- JavaScript/Node.js
105+
- Ruby
87106
validations:
88107
required: true
89-
- type: input
90-
id: selenium-grid-version
108+
- type: dropdown
109+
id: browsers
110+
attributes:
111+
label: Which browsers are you experiencing the issue with?
112+
multiple: true
113+
options:
114+
- Chrome
115+
- Firefox
116+
- Edge
117+
- Safari
118+
- IE
119+
- Other (please specify in the description)
120+
- type: dropdown
121+
id: grid
91122
attributes:
92123
label: Are you using Selenium Grid?
93-
description: What version of Selenium Grid are you using?
94-
placeholder: Example - 4.0.0
124+
options:
125+
- "No"
126+
- "Yes"
127+
validations:
128+
required: true
Lines changed: 41 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,53 @@
11
name: 🚀 Feature Proposal
2-
description: Propose a feature
2+
description: Suggest a new feature or improvement to Selenium
33
title: "[🚀 Feature]: "
4-
labels: [ I-enhancement, needs-triaging ]
4+
labels: [ I-enhancement, A-needs-triaging ]
55
body:
6-
- type: markdown
7-
attributes:
8-
value: |
9-
Thanks for taking the time to propose a feature!
106
- type: textarea
11-
id: feature-description
7+
id: description
128
attributes:
13-
label: Feature and motivation
14-
description: |
15-
Describe clearly and concisely the feature you are proposing, what is the motivation
16-
behind it.
9+
label: Description
1710
placeholder: |
18-
Help us to understand your proposal by adding as many details as possible, we will look into
19-
it and give you feedback as soon as possible.
11+
What would you like Selenium to support or do differently?
12+
Please include:
13+
- The problem this would solve
14+
- How you expect the feature would work
15+
- Any relevant context or use cases
16+
- Links to related issues, discussions, or external tools (if applicable)
2017
validations:
2118
required: true
19+
2220
- type: textarea
23-
id: feature-example
21+
id: alternatives
2422
attributes:
25-
label: Usage example
26-
description: |
27-
How would you use this feature?
23+
label: Have you considered any alternatives or workarounds?
2824
placeholder: |
29-
A clear example showing how this feature is useful for you and the Selenium community.
25+
If you've tried other ways to solve this problem, describe them here.
26+
If not, you can leave this blank.
3027
validations:
31-
required: true
28+
required: false
29+
30+
- type: dropdown
31+
id: bindings
32+
attributes:
33+
label: Does this apply to specific language bindings?
34+
multiple: true
35+
options:
36+
- Java
37+
- Python
38+
- C#/.NET
39+
- JavaScript/Node.js
40+
- Ruby
41+
42+
- type: dropdown
43+
id: components
44+
attributes:
45+
label: What part(s) of Selenium does this relate to?
46+
multiple: true
47+
options:
48+
- Atoms
49+
- Build (CI or Bazel)
50+
- DevTools (CDP or BiDi)
51+
- Documentation
52+
- Grid
53+
- Selenium Manager

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
1-
**Thanks for contributing to Selenium!**
2-
**A PR well described will help maintainers to quickly review and merge it**
1+
<!-- Thanks for Contributing to Selenium! -->
2+
<!-- Please read our contribution guidelines: https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md -->
33

4-
Before submitting your PR, please check our [contributing](https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md) guidelines.
5-
Avoid large PRs, help reviewers by making them as simple and short as possible.
4+
### 🔗 Related Issues
5+
<!-- Example: Fixes #1234 or Closes #5678 -->
6+
<!-- If the reason for this PR is not obvious, consider creating an issue for it first -->
67

7-
<!--- Provide a general summary of your changes in the Title above -->
8+
### 💥 What does this PR do?
9+
<!-- Describe what this change includes and how it works -->
810

9-
### Motivation and Context
10-
<!--- Why is this change required? What problem does it solve? -->
11+
### 🔧 Implementation Notes
12+
<!--- Why did you implement it this way? -->
13+
<!--- What alternatives to this approach did you consider? -->
1114

12-
### Types of changes
13-
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
14-
- [ ] Bug fix (non-breaking change which fixes an issue)
15-
- [ ] New feature (non-breaking change which adds functionality)
16-
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
15+
### 💡 Additional Considerations
16+
<!--- Are there any decisions that need to be made before accepting this PR? -->
17+
<!--- Is there any follow-on work that needs to be done? (e.g., docs, tests, etc.) -->
1718

18-
### Checklist
19-
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
20-
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
21-
- [ ] I have read the [contributing](https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md) document.
22-
- [ ] My change requires a change to the documentation.
23-
- [ ] I have updated the documentation accordingly.
24-
- [ ] I have added tests to cover my changes.
25-
- [ ] All new and existing tests passed.
26-
<!--- Provide a general summary of your changes in the Title above -->
19+
### 🔄 Types of changes
20+
<!-- ✂️ Please delete anything that doesn't apply -->
21+
- Cleanup (formatting, renaming)
22+
- Bug fix (backwards compatible)
23+
- New feature (non-breaking change which adds functionality *and tests!*)
24+
- Breaking change (fix or feature that would cause existing functionality to change)

.github/issue-labeler-config.yml

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
policy:
2+
- section:
3+
- id: [operating-system]
4+
label:
5+
- name: OS-windows
6+
keys: [ Windows ]
7+
- name: OS-mac
8+
keys: [ macOS ]
9+
- name: OS-linux
10+
keys: [ Linux (specify in the description) ]
11+
12+
- id: [bindings]
13+
label:
14+
- name: C-java
15+
keys: [ Java ]
16+
- name: C-py
17+
keys: [ Python ]
18+
- name: C-dotnet
19+
keys: [ C#/.NET ]
20+
- name: C-rb
21+
keys: [ Ruby ]
22+
- name: C-nodejs
23+
keys: [ JavaScript/Node.js ]
24+
25+
- id: [regression]
26+
label:
27+
- name: I-regression
28+
keys: [ Yes this is a regression ]
29+
30+
- id: [components]
31+
label:
32+
- name: B-grid
33+
keys: [ Grid ]
34+
- name: B-docs
35+
keys: [ Documentation ]
36+
- name: B-devtools
37+
keys: [ DevTools (CDP or BiDi) ]
38+
- name: B-manager
39+
keys: [ Selenium Manager ]
40+
- name: B-build
41+
keys: [ Build (CI or Bazel) ]
42+
- name: B-atoms
43+
keys: [ Atoms ]
44+
45+
- id: [browsers]
46+
label:
47+
- name: D-chrome
48+
keys: [ Chrome ]
49+
- name: D-firefox
50+
keys: [ Firefox ]
51+
- name: D-safari
52+
keys: [ Safari ]
53+
- name: D-edge
54+
keys: [ Edge ]
55+
- name: D-IE
56+
keys: [ IE ]
57+
58+
- id: [grid]
59+
label:
60+
- name: B-grid
61+
keys: [ "Yes" ]

0 commit comments

Comments
 (0)