Merge branch 'trunk' into final-python-pagesize-support

Author: yvsvarma

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,12 +4,8 @@
 Before submitting your PR, please check our [contributing](https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md) guidelines.
 Avoid large PRs, help reviewers by making them as simple and short as possible.
 
-
 <!--- Provide a general summary of your changes in the Title above -->
 
-### Description
-<!--- Describe your changes in detail -->
-
 ### Motivation and Context
 <!--- Why is this change required? What problem does it solve? -->
 

README.md

@@ -1,10 +1,25 @@
-# Selenium
-
-[![CI](https://github.com/SeleniumHQ/selenium/actions/workflows/ci.yml/badge.svg?branch=trunk&event=schedule)](https://github.com/SeleniumHQ/selenium/actions/workflows/ci.yml)
-[![CI - RBE](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rbe.yml/badge.svg?branch=trunk&event=schedule)](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rbe.yml)
-[![Releases downloads](https://img.shields.io/github/downloads/SeleniumHQ/selenium/total.svg)](https://github.com/SeleniumHQ/selenium/releases)
-
-<a href="https://selenium.dev"><img src="common/images/selenium_logo_mark_green.svg" width="180" alt="Selenium Logo"/></a>
+<h1 align="center">
+  <br/>
+  <a href="https://selenium.dev"><img src="common/images/selenium_logo_mark_green.svg" alt="Selenium" width="100"></a>
+  <br/>
+  Selenium
+  <br/>
+</h1>
+
+<h3 align="center">Automates browsers. That's it!</h3>
+
+<p align="center">
+  <a href="#contributing">Contributing</a> •
+  <a href="#installing">Installing</a> •
+  <a href="#building">Building</a> •
+  <a href="#developing">Developing</a> •
+  <a href="#testing">Testing</a> •
+  <a href="#documenting">Documenting</a> •
+  <a href="#releasing">Releasing</a> •
+  <a href="#license">License</a>
+</p>
+
+<br>
 
 Selenium is an umbrella project encapsulating a variety of tools and
 libraries enabling web browser automation. Selenium specifically
@@ -15,13 +30,15 @@ major web browsers.
 The project is made possible by volunteer contributors who've
 generously donated thousands of hours in code development and upkeep.
 
-Selenium's source code is made available under the [Apache 2.0 license](https://github.com/SeleniumHQ/selenium/blob/trunk/LICENSE).
-
 This README is for developers interested in contributing to the project.
 For people looking to get started using Selenium, please check out
 our [User Manual](https://selenium.dev/documentation/) for detailed examples and descriptions, and if you
 get stuck, there are several ways to [Get Help](https://www.selenium.dev/support/).
 
+[![CI](https://github.com/SeleniumHQ/selenium/actions/workflows/ci.yml/badge.svg)](https://github.com/SeleniumHQ/selenium/actions/workflows/ci.yml)
+[![CI - RBE](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rbe.yml/badge.svg)](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rbe.yml)
+[![Releases downloads](https://img.shields.io/github/downloads/SeleniumHQ/selenium/total.svg)](https://github.com/SeleniumHQ/selenium/releases)
+
 ## Contributing
 
 Please read [CONTRIBUTING.md](https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md)
@@ -507,3 +524,7 @@ If you have access to the Selenium EngFlow repository, you can have the assets b
 ```shell
 ./go all:release['--config', 'release']
 ```
+
+## License
+
+Selenium's source code is made available under the [Apache 2.0 license](https://github.com/SeleniumHQ/selenium/blob/trunk/LICENSE).

dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs

@@ -18,6 +18,7 @@
 // </copyright>
 
 using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
+using System;
 using System.Threading.Tasks;
 
 #nullable enable
@@ -28,11 +29,18 @@ public static class WebDriverExtensions
 {
     public static async Task<BiDi> AsBiDiAsync(this IWebDriver webDriver)
     {
-        var webSocketUrl = ((IHasCapabilities)webDriver).Capabilities.GetCapability("webSocketUrl");
+        if (webDriver is null) throw new ArgumentNullException(nameof(webDriver));
 
-        if (webSocketUrl is null) throw new System.Exception("The driver is not compatible with bidirectional protocol or it is not enabled in driver options.");
+        string? webSocketUrl = null;
 
-        var bidi = await BiDi.ConnectAsync(webSocketUrl.ToString()!).ConfigureAwait(false);
+        if (webDriver is IHasCapabilities hasCapabilities)
+        {
+            webSocketUrl = hasCapabilities.Capabilities.GetCapability("webSocketUrl")?.ToString();
+        }
+
+        if (webSocketUrl is null) throw new BiDiException("The driver is not compatible with bidirectional protocol or \"webSocketUrl\" not enabled in driver options.");
+
+        var bidi = await BiDi.ConnectAsync(webSocketUrl).ConfigureAwait(false);
 
         return bidi;
     }