Merge branch 'trunk' into remove_line_ending_manipulation

Author: pujagani

dotnet/src/support/UI/LoadableComponentException.cs

@@ -57,17 +57,5 @@ public LoadableComponentException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="LoadableComponentException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected LoadableComponentException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/support/UI/UnexpectedTagNameException.cs

@@ -69,17 +69,5 @@ public UnexpectedTagNameException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="UnexpectedTagNameException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected UnexpectedTagNameException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/DetachedShadowRootException.cs

@@ -57,17 +57,5 @@ public DetachedShadowRootException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DetachedShadowRootException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected DetachedShadowRootException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/DevTools/DevToolsSession.cs

@@ -16,6 +16,7 @@
 // limitations under the License.
 // </copyright>
 
+using OpenQA.Selenium.Internal.Logging;
 using System;
 using System.Collections.Concurrent;
 using System.Globalization;
@@ -56,6 +57,8 @@ public class DevToolsSession : IDevToolsSession
         private DevToolsDomains domains;
         private readonly DevToolsOptions options;
 
+        private readonly static ILogger logger = Internal.Logging.Log.GetLogger<DevToolsSession>();
+
         /// <summary>
         /// Initializes a new instance of the DevToolsSession class, using the specified WebSocket endpoint.
         /// </summary>
@@ -272,6 +275,11 @@ public T GetVersionSpecificDomains<T>() where T : DevToolsSessionDomains
 
             if (this.connection != null && this.connection.IsActive)
             {
+                if (logger.IsEnabled(LogEventLevel.Trace))
+                {
+                    logger.Trace($"CDP SND >> {message.CommandId} {message.CommandName}: {commandParameters.ToJsonString()}");
+                }
+
                 LogTrace("Sending {0} {1}: {2}", message.CommandId, message.CommandName, commandParameters.ToString());
 
                 string contents = JsonSerializer.Serialize(message);
@@ -540,6 +548,11 @@ private void MonitorMessageQueue()
 
         private void ProcessMessage(string message)
         {
+            if (logger.IsEnabled(LogEventLevel.Trace))
+            {
+                logger.Trace($"CDP RCV << {message}");
+            }
+
             var messageObject = JsonObject.Parse(message).AsObject();
 
             if (messageObject.TryGetPropertyValue("id", out var idProperty))
@@ -583,7 +596,22 @@ private void ProcessMessage(string message)
                 // DevTools commands that may be sent in the body of the attached
                 // event handler. If thread pool starvation seems to become a problem,
                 // we can switch to a channel-based queue.
-                Task.Run(() => OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData)));
+                Task.Run(() =>
+                {
+                    try
+                    {
+                        OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData));
+                    }
+                    catch (Exception ex)
+                    {
+                        if (logger.IsEnabled(LogEventLevel.Warn))
+                        {
+                            logger.Warn($"CDP VNT ^^ Unhandled error occured in event handler of '{method}' method. {ex}");
+                        }
+
+                        throw;
+                    }
+                });
 
                 return;
             }

dotnet/src/webdriver/DriverService.cs

@@ -16,7 +16,6 @@
 // limitations under the License.
 // </copyright>
 
-using OpenQA.Selenium.Internal.Logging;
 using OpenQA.Selenium.Remote;
 using System;
 using System.Diagnostics;
@@ -42,7 +41,6 @@ public abstract class DriverService : ICommandServer
         private bool isDisposed;
         private Process driverServiceProcess;
         private TimeSpan initializationTimeout = TimeSpan.FromSeconds(20);
-        private readonly static ILogger logger = Log.GetLogger<DriverService>();
 
         /// <summary>
         /// Initializes a new instance of the <see cref="DriverService"/> class.
@@ -238,10 +236,7 @@ protected virtual bool IsInitialized
                 }
                 catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)
                 {
-                    if (logger.IsEnabled(LogEventLevel.Trace))
-                    {
-                        logger.Trace(ex.ToString());
-                    }
+                    // Do nothing. The exception is expected, meaning driver service is not initialized.
                 }
 
                 return isInitialized;

dotnet/src/webdriver/DriverServiceNotFoundException.cs

@@ -57,17 +57,5 @@ public DriverServiceNotFoundException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DriverServiceNotFoundException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected DriverServiceNotFoundException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/ElementClickInterceptedException.cs

@@ -57,17 +57,5 @@ public ElementClickInterceptedException(string message, Exception innerException
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ElementNotInteractableException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected ElementClickInterceptedException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/ElementNotInteractableException.cs

@@ -57,17 +57,5 @@ public ElementNotInteractableException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ElementNotInteractableException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected ElementNotInteractableException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/ElementNotSelectableException.cs

@@ -57,17 +57,5 @@ public ElementNotSelectableException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ElementNotInteractableException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected ElementNotSelectableException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

dotnet/src/webdriver/ElementNotVisibleException.cs

@@ -57,17 +57,5 @@ public ElementNotVisibleException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ElementNotVisibleException"/> class with serialized data.
-        /// </summary>
-        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized
-        /// object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual
-        /// information about the source or destination.</param>
-        protected ElementNotVisibleException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }