Skip to content

Commit e9fce05

Browse files
committed
Address some warnings
1 parent bdb7ea0 commit e9fce05

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

dotnet/src/webdriver/BUILD.bazel

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ csharp_library(
3636
internals_visible_to = [
3737
"WebDriver.Common.Tests",
3838
],
39-
langversion = "13.0",
39+
langversion = "12.0",
4040
nullable = "enable",
4141
resources = [
4242
"//javascript/atoms/fragments:find-elements.js",
@@ -76,7 +76,7 @@ csharp_library(
7676
internals_visible_to = [
7777
"WebDriver.Common.Tests",
7878
],
79-
langversion = "13.0",
79+
langversion = "12.0",
8080
nullable = "enable",
8181
resources = [
8282
"//javascript/atoms/fragments:find-elements.js",
@@ -104,7 +104,7 @@ csharp_library(
104104
]) + devtools_version_targets(),
105105
out = "WebDriver.StrongNamed",
106106
keyfile = "//dotnet:WebDriver.snk",
107-
langversion = "13.0",
107+
langversion = "12.0",
108108
nullable = "enable",
109109
resources = [
110110
"//javascript/atoms/fragments:find-elements.js",
@@ -142,7 +142,7 @@ csharp_library(
142142
"NET8_0_OR_GREATER",
143143
],
144144
keyfile = "//dotnet:WebDriver.snk",
145-
langversion = "13.0",
145+
langversion = "12.0",
146146
nullable = "enable",
147147
resources = [
148148
"//javascript/atoms/fragments:find-elements.js",

dotnet/src/webdriver/BiDi/Communication/Broker.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,22 +375,28 @@ private void ProcessReceivedMessage(byte[]? data)
375375
switch (type)
376376
{
377377
case "success":
378+
if (id is null) throw new BiDiException("The remote end responded with 'success' message type, but missed required 'id' property.");
379+
378380
var successCommand = _pendingCommands[id.Value];
379-
var messageSuccess = JsonSerializer.Deserialize(ref resultReader, successCommand.Item1.ResultType, _jsonSerializerContext);
381+
var messageSuccess = JsonSerializer.Deserialize(ref resultReader, successCommand.Item1.ResultType, _jsonSerializerContext)!;
380382
successCommand.Item2.SetResult(messageSuccess);
381383
_pendingCommands.TryRemove(id.Value, out _);
382384
break;
383385

384386
case "event":
387+
if (method is null) throw new BiDiException("The remote end responded with 'event' message type, but missed required 'method' property.");
388+
385389
var eventType = _eventTypesMap[method];
386390

387-
var eventArgs = (EventArgs)JsonSerializer.Deserialize(ref paramsReader, eventType, _jsonSerializerContext);
391+
var eventArgs = (EventArgs)JsonSerializer.Deserialize(ref paramsReader, eventType, _jsonSerializerContext)!;
388392

389393
var messageEvent = new MessageEvent(method, eventArgs);
390394
_pendingEvents.Add(messageEvent);
391395
break;
392396

393397
case "error":
398+
if (id is null) throw new BiDiException("The remote end responded with 'error' message type, but missed required 'id' property.");
399+
394400
var messageError = new MessageError(id.Value) { Error = error, Message = message };
395401
var errorCommand = _pendingCommands[messageError.Id];
396402
errorCommand.Item2.SetException(new BiDiException($"{messageError.Error}: {messageError.Message}"));

dotnet/src/webdriver/WebDriver.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<TargetFrameworks>netstandard2.0;net8.0;</TargetFrameworks>
55
<AssemblyName>WebDriver</AssemblyName>
66
<RootNamespace>OpenQA.Selenium</RootNamespace>
7-
<LangVersion>13.0</LangVersion>
7+
<LangVersion>12.0</LangVersion>
88
<Nullable>enable</Nullable>
99
</PropertyGroup>
1010

0 commit comments

Comments
 (0)