make webdriver bidi session private

Author: navin772

py/selenium/webdriver/remote/webdriver.py

@@ -257,7 +257,7 @@ def __init__(
         self._script = None
         self._network = None
         self._browser = None
-        self._session = None
+        self._bidi_session = None
 
     def __repr__(self):
         return f'<{type(self).__module__}.{type(self).__name__} (session="{self.session_id}")>'
@@ -1297,22 +1297,17 @@ def browser(self):
         return self._browser
 
     @property
-    def session(self):
-        """Returns the BiDi session object for the current WebDriver session.
-
-        Example:
-        --------
-        >>> driver.session.subscribe()
-        >>> driver.session.unsubscribe()
-        >>> session = driver.session.status()
+    def _session(self):
+        """
+        Returns the BiDi session object for the current WebDriver session.
         """
         if not self._websocket_connection:
             self._start_bidi()
 
-        if self._session is None:
-            self._session = Session(self._websocket_connection)
+        if self._bidi_session is None:
+            self._bidi_session = Session(self._websocket_connection)
 
-        return self._session
+        return self._bidi_session
 
     def _get_cdp_details(self):
         import json

py/test/selenium/webdriver/common/bidi_session_tests.py

@@ -22,7 +22,7 @@
 
 @pytest.mark.xfail_safari
 def test_session_status(driver):
-    result = driver.session.status()
+    result = driver._session.status()
     assert result is not None
     assert "ready" in result
     assert "message" in result
@@ -33,7 +33,7 @@ def test_session_status(driver):
 @pytest.mark.xfail_safari
 def test_session_status_not_closed_with_one_window(driver):
     # initial session status
-    initial_status = driver.session.status()
+    initial_status = driver._session.status()
     assert initial_status is not None
 
     # Open new window and tab
@@ -44,7 +44,7 @@ def test_session_status_not_closed_with_one_window(driver):
     driver.close()
 
     # Session should still be active
-    status_after_closing = driver.session.status()
+    status_after_closing = driver._session.status()
     assert status_after_closing is not None
     assert "ready" in status_after_closing
     assert "message" in status_after_closing