Skip to content

Commit ed47fde

Browse files
[rb]modified delete cookie code for ruby
1 parent 10cc4d3 commit ed47fde

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

rb/lib/selenium/webdriver/remote/bridge.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -385,16 +385,12 @@ def add_cookie(cookie)
385385
end
386386

387387
def delete_cookie(name)
388-
if ( name.nil? || name.empty?) then
389-
raise Error::ArgumentError, 'Cookie name cannot be null or empty'
390-
end
388+
raise Error::ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.empty?
391389
execute :delete_cookie, name: name
392390
end
393391

394392
def cookie(name)
395-
if ( name.nil? || name.empty?) then
396-
raise Error::ArgumentError, 'Cookie name cannot be null or empty'
397-
end
393+
raise Error::ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.empty?
398394
execute :get_cookie, name: name
399395
end
400396

rb/spec/integration/selenium/webdriver/manager_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,11 @@ module WebDriver
242242
expect(driver.manage.all_cookies.find { |c| c[:name] == 'foo' }).to be_nil
243243
end
244244

245+
it 'throws error when cookie name is empty string' do
246+
expect { driver.manage.delete_cookie('') }
247+
.to raise_exception(Error::ArgumentError)
248+
end
249+
245250
it 'deletes all' do
246251
driver.manage.add_cookie name: 'foo', value: 'bar'
247252
driver.manage.add_cookie name: 'bar', value: 'foo'

0 commit comments

Comments
 (0)