remove null check from FileLogHandler

RenderMichael · RenderMichael · commit edd0fdba0ec5 · 2024-11-27T16:25:14.000-05:00
diff --git a/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs b/dotnet/src/webdriver/Internal/Logging/FileLogHandler.cs
@@ -80,14 +80,9 @@ public FileLogHandler(string filePath, bool overwrite)
         /// <param name="logEvent">The log event to handle.</param>
         public void Handle(LogEvent logEvent)
         {
-            if (_streamWriter is not { } writer)
-            {
-                throw new ObjectDisposedException(nameof(FileLogHandler));
-            }
-
             lock (_lockObj)
             {
-                writer.WriteLine($"{logEvent.Timestamp:yyyy-MM-dd HH:mm:ss.fff} {_levels[(int)logEvent.Level]} {logEvent.IssuedBy.Name}: {logEvent.Message}");
+                _streamWriter.WriteLine($"{logEvent.Timestamp:yyyy-MM-dd HH:mm:ss.fff} {_levels[(int)logEvent.Level]} {logEvent.IssuedBy.Name}: {logEvent.Message}");
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -80,14 +80,9 @@ public FileLogHandler(string filePath, bool overwrite)`
`80`	`80`	`/// <param name="logEvent">The log event to handle.</param>`
`81`	`81`	`public void Handle(LogEvent logEvent)`
`82`	`82`	`{`
`83`		`- if (_streamWriter is not { } writer)`
`84`		`- {`
`85`		`- throw new ObjectDisposedException(nameof(FileLogHandler));`
`86`		`- }`
`87`		`-`
`88`	`83`	`lock (_lockObj)`
`89`	`84`	`{`
`90`		`- writer.WriteLine($"{logEvent.Timestamp:yyyy-MM-dd HH:mm:ss.fff} {_levels[(int)logEvent.Level]} {logEvent.IssuedBy.Name}: {logEvent.Message}");`
	`85`	`+ _streamWriter.WriteLine($"{logEvent.Timestamp:yyyy-MM-dd HH:mm:ss.fff} {_levels[(int)logEvent.Level]} {logEvent.IssuedBy.Name}: {logEvent.Message}");`
`91`	`86`	`}`
`92`	`87`	`}`
`93`	`88`