Skip to content

Commit ef39df0

Browse files
committed
[rust] Include flag --selenium-version to specify the Selenium version (#15754)
1 parent 4768f5a commit ef39df0

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

rust/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ pub const NOT_ADMIN_FOR_EDGE_INSTALLER_ERR_MSG: &str =
111111
"{} can only be installed in Windows with administrator permissions";
112112
pub const ONLINE_DISCOVERY_ERROR_MESSAGE: &str = "Unable to discover {}{} in online repository";
113113
pub const UNC_PREFIX: &str = r"\\?\";
114-
pub const SM_BETA_LABEL: &str = "0.";
115114

116115
pub trait SeleniumManager {
117116
// ----------------------------------------------------------

rust/src/main.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ use selenium_manager::grid::GridManager;
2525
use selenium_manager::lock::clear_lock_if_required;
2626
use selenium_manager::logger::{Logger, BROWSER_PATH, DRIVER_PATH};
2727
use selenium_manager::metadata::clear_metadata;
28+
use selenium_manager::REQUEST_TIMEOUT_SEC;
2829
use selenium_manager::TTL_SEC;
2930
use selenium_manager::{
3031
clear_cache, get_manager_by_browser, get_manager_by_driver, SeleniumManager,
3132
};
32-
use selenium_manager::{REQUEST_TIMEOUT_SEC, SM_BETA_LABEL};
3333
use std::backtrace::{Backtrace, BacktraceStatus};
3434
use std::path::Path;
3535
use std::process::exit;
@@ -145,6 +145,10 @@ struct Cli {
145145
#[clap(long)]
146146
language_binding: Option<String>,
147147

148+
/// Selenium version (to be sent to plausible.io)
149+
#[clap(long, value_parser, default_value = "")]
150+
selenium_version: String,
151+
148152
/// Avoid sends usage statistics to plausible.io
149153
#[clap(long)]
150154
avoid_stats: bool,
@@ -223,9 +227,7 @@ fn main() {
223227
selenium_manager.set_cache_path(cache_path.clone());
224228
selenium_manager.set_offline(cli.offline);
225229
selenium_manager.set_language_binding(cli.language_binding.unwrap_or_default());
226-
let sm_version = clap::crate_version!();
227-
let selenium_version = sm_version.strip_prefix(SM_BETA_LABEL).unwrap_or(sm_version);
228-
selenium_manager.set_selenium_version(selenium_version.to_string());
230+
selenium_manager.set_selenium_version(cli.selenium_version);
229231
selenium_manager.set_avoid_stats(cli.avoid_stats);
230232
selenium_manager.set_skip_driver_in_path(cli.skip_driver_in_path);
231233
selenium_manager.set_skip_browser_in_path(cli.skip_browser_in_path);

0 commit comments

Comments
 (0)