Update index.js

harsha509 · web-flow · commit f09413314217 · 2025-03-30T16:30:34.000-04:00
Fix race condition!
diff --git a/javascript/selenium-webdriver/index.js b/javascript/selenium-webdriver/index.js
@@ -680,10 +680,14 @@ class Builder {
         if (this.firefoxService_) {
           service = this.firefoxService_.build()
         }
+
+        // Find a free port before starting Firefox
+        const port = portprober.findFreePort();
+        
         // Allocate a free port for the websocket only when not connecting to an existing instance
         // This avoids conflicts when multiple Firefox instances have started
         if (!service?.options_.args.includes('--connect-existing')) {
-          service?.addArguments('--websocket-port', `${portprober.findFreePort()}`)
+          service?.addArguments('--websocket-port', `${port}`)
         }
         return createDriver(firefox.Driver, capabilities, service)
       }

Original file line number	Diff line number	Diff line change
`@@ -680,10 +680,14 @@ class Builder {`
`680`	`680`	`if (this.firefoxService_) {`
`681`	`681`	`service = this.firefoxService_.build()`
`682`	`682`	`}`
	`683`	`+`
	`684`	`+ // Find a free port before starting Firefox`
	`685`	`+ const port = portprober.findFreePort();`
	`686`	`+`
`683`	`687`	`// Allocate a free port for the websocket only when not connecting to an existing instance`
`684`	`688`	`// This avoids conflicts when multiple Firefox instances have started`
`685`	`689`	`if (!service?.options_.args.includes('--connect-existing')) {`
`686`		- service?.addArguments('--websocket-port', `${portprober.findFreePort()}`)
	`690`	+ service?.addArguments('--websocket-port', `${port}`)
`687`	`691`	`}`
`688`	`692`	`return createDriver(firefox.Driver, capabilities, service)`
`689`	`693`	`}`