Skip to content

Commit f277ccf

Browse files
committed
[rb] mark low level bidi implementation as private api
1 parent 13b63f6 commit f277ccf

File tree

13 files changed

+56
-1
lines changed

13 files changed

+56
-1
lines changed

rb/lib/selenium/webdriver/bidi/browser.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# BiDi Implementation of the Browser Module
25+
# Continue to use functionality from existing `driver.manager.window` method
26+
#
27+
# @api private
28+
#
29+
2330
class Browser
2431
Window = Struct.new(:handle, :active, :height, :width, :x, :y, :state) do
2532
def active?

rb/lib/selenium/webdriver/bidi/browsing_context.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23-
# Implements the browsingContext Module of the WebDriver-BiDi specification
23+
# Implements the BrowsingContext Module of the WebDriver-BiDi specification
24+
# Continue to use functionality from existing `driver.navigate` method
2425
#
2526
# @api private
2627
#

rb/lib/selenium/webdriver/bidi/log_handler.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
# Implements the Log of the WebDriver-BiDi specification
24+
# This functionality should be accessed through `driver.script` method
25+
#
26+
# @api private
27+
#
2328
class LogHandler
2429
ConsoleLogEntry = BiDi::Struct.new(:level, :text, :timestamp, :stack_trace, :type, :source, :method, :args)
2530
JavaScriptLogEntry = BiDi::Struct.new(:level, :text, :timestamp, :stack_trace, :type, :source)

rb/lib/selenium/webdriver/bidi/network.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@
2121
module Selenium
2222
module WebDriver
2323
class BiDi
24+
# Implements the Navigation Module of the WebDriver-BiDi specification
25+
# Continue to use functionality from existing `driver.navigate` method
26+
#
27+
# @api private
28+
#
29+
2430
class Network
2531
EVENTS = {
2632
before_request: 'network.beforeRequestSent',

rb/lib/selenium/webdriver/bidi/network/cookies.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# @api private
25+
#
26+
2327
class Cookies < Hash
2428
def as_json
2529
map do |name, val|

rb/lib/selenium/webdriver/bidi/network/credentials.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# @api private
25+
#
26+
2327
class Credentials
2428
attr_accessor :username, :password
2529

rb/lib/selenium/webdriver/bidi/network/headers.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# @api private
25+
#
26+
2327
class Headers < Hash
2428
def as_json
2529
map do |name, val|

rb/lib/selenium/webdriver/bidi/network/intercepted_auth.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# @api private
25+
#
26+
2327
class InterceptedAuth < InterceptedItem
2428
def authenticate(username, password)
2529
network.continue_with_auth(id, username, password)

rb/lib/selenium/webdriver/bidi/network/intercepted_item.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
module Selenium
2121
module WebDriver
2222
class BiDi
23+
#
24+
# @api private
25+
#
26+
2327
class InterceptedItem
2428
attr_reader :network, :request
2529

rb/lib/selenium/webdriver/bidi/network/intercepted_request.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
module Selenium
2424
module WebDriver
2525
class BiDi
26+
#
27+
# @api private
28+
#
29+
2630
class InterceptedRequest < InterceptedItem
2731
attr_accessor :method, :url
2832
attr_reader :body

0 commit comments

Comments
 (0)