InvalidSelectorException now extends WebDriverException

Fixes #10833

Author: diemol

dotnet/src/webdriver/InvalidSelectorException.cs

@@ -25,7 +25,7 @@ namespace OpenQA.Selenium
     /// The exception that is thrown when an element is not visible.
     /// </summary>
     [Serializable]
-    public class InvalidSelectorException : NoSuchElementException
+    public class InvalidSelectorException : WebDriverException
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="InvalidSelectorException"/> class.

dotnet/test/common/ElementFindingTest.cs

@@ -84,7 +84,7 @@ public void ShouldNotBeAbleToLocateByIdMultipleElementsThatDoNotExist()
         public void FindingASingleElementByEmptyIdShouldThrow()
         {
             driver.Url = formsPage;
-            Assert.That(() => driver.FindElement(By.Id("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElement(By.Id("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
@@ -222,7 +222,7 @@ public void ShouldNotBeAbleToLocateByTagNameMultipleElementsThatDoNotExist()
         public void FindingASingleElementByEmptyTagNameShouldThrow()
         {
             driver.Url = formsPage;
-            Assert.That(() => driver.FindElement(By.TagName("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElement(By.TagName("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
@@ -312,14 +312,14 @@ public void ShouldNotFindElementByClassWhenTheNameQueriedIsShorterThanCandidateN
         public void FindingASingleElementByEmptyClassNameShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElement(By.ClassName("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElement(By.ClassName("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
         public void FindingMultipleElementsByEmptyClassNameShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElements(By.ClassName("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElements(By.ClassName("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
@@ -600,28 +600,28 @@ public void ShouldNotFindElementsByCssSelectorWhenThereIsNoSuchElement()
         public void FindingASingleElementByEmptyCssSelectorShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElement(By.CssSelector("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElement(By.CssSelector("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
         public void FindingMultipleElementsByEmptyCssSelectorShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElements(By.CssSelector("")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElements(By.CssSelector("")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
         public void FindingASingleElementByInvalidCssSelectorShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElement(By.CssSelector("//a/b/c[@id='1']")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElement(By.CssSelector("//a/b/c[@id='1']")), Throws.InstanceOf<WebDriverException>());
         }
 
         [Test]
         public void FindingMultipleElementsByInvalidCssSelectorShouldThrow()
         {
             driver.Url = xhtmlTestPage;
-            Assert.That(() => driver.FindElements(By.CssSelector("//a/b/c[@id='1']")), Throws.InstanceOf<NoSuchElementException>());
+            Assert.That(() => driver.FindElements(By.CssSelector("//a/b/c[@id='1']")), Throws.InstanceOf<WebDriverException>());
         }
 
         // By.linkText positive