Skip to content

Commit f3caceb

Browse files
committed
better cleanup
1 parent a72c4c8 commit f3caceb

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

py/test/selenium/webdriver/common/bidi_emulation_tests.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -347,17 +347,18 @@ def test_set_locale_override_with_contexts(driver, pages, locale, expected_local
347347
def test_set_locale_override_with_user_contexts(driver, pages, value):
348348
"""Test setting locale override with user contexts."""
349349
user_context = driver.browser.create_user_context()
350+
try:
351+
context_id = driver.browsing_context.create(type=WindowTypes.TAB, user_context=user_context)
352+
try:
353+
driver.switch_to.window(context_id)
350354

351-
context_id = driver.browsing_context.create(type=WindowTypes.TAB, user_context=user_context)
352-
353-
driver.switch_to.window(context_id)
355+
driver.emulation.set_locale_override(locale=value, user_contexts=[user_context])
354356

355-
driver.emulation.set_locale_override(locale=value, user_contexts=[user_context])
356-
357-
driver.browsing_context.navigate(context_id, pages.url("formPage.html"), wait="complete")
357+
driver.browsing_context.navigate(context_id, pages.url("formPage.html"), wait="complete")
358358

359-
current_locale = get_browser_locale(driver)
360-
assert current_locale == value, f"Expected locale {value}, got {current_locale}"
361-
362-
driver.browsing_context.close(context_id)
363-
driver.browser.remove_user_context(user_context)
359+
current_locale = get_browser_locale(driver)
360+
assert current_locale == value, f"Expected locale {value}, got {current_locale}"
361+
finally:
362+
driver.browsing_context.close(context_id)
363+
finally:
364+
driver.browser.remove_user_context(user_context)

0 commit comments

Comments
 (0)