[py] Use mocks in tests

Author: cgoldberg

py/test/selenium/webdriver/chrome/chrome_service_tests.py

@@ -17,7 +17,6 @@
 import os
 import subprocess
 import time
-
 from unittest.mock import patch
 
 import pytest

py/test/selenium/webdriver/chrome/proxy_tests.py

@@ -15,8 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-import os
-
 from unittest.mock import patch
 
 import pytest

py/test/selenium/webdriver/edge/edge_service_tests.py

@@ -17,7 +17,6 @@
 import os
 import subprocess
 import time
-
 from unittest.mock import patch
 
 import pytest

py/test/selenium/webdriver/firefox/firefox_service_tests.py

@@ -16,7 +16,6 @@
 # under the License.
 import os
 import subprocess
-
 from unittest.mock import patch
 
 import pytest

py/test/selenium/webdriver/safari/safari_service_tests.py

@@ -16,7 +16,6 @@
 # under the License.
 
 import os
-
 from unittest.mock import patch
 
 import pytest

py/test/unit/selenium/webdriver/remote/remote_connection_tests.py

@@ -15,7 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-import os
 from unittest.mock import patch
 from urllib import parse
 
@@ -168,18 +167,17 @@ def test_get_proxy_direct_via_client_config():
 
 
 def test_get_proxy_system_matches_no_proxy_via_client_config():
-    os.environ["HTTP_PROXY"] = "http://admin:admin@system_proxy.com:8080"
-    os.environ["NO_PROXY"] = "localhost,127.0.0.1"
-    client_config = ClientConfig(
-        remote_server_addr="http://localhost:4444", proxy=Proxy({"proxyType": ProxyType.SYSTEM})
-    )
-    remote_connection = RemoteConnection(client_config=client_config)
-    conn = remote_connection._get_connection_manager()
-    assert isinstance(conn, urllib3.PoolManager)
-    proxy_url = remote_connection._client_config.get_proxy_url()
-    assert proxy_url is None
-    os.environ.pop("HTTP_PROXY")
-    os.environ.pop("NO_PROXY")
+    with patch.dict(
+        "os.environ", {"HTTP_PROXY": "http://admin:admin@system_proxy.com:8080", "NO_PROXY": "localhost,127.0.0.1"}
+    ):
+        client_config = ClientConfig(
+            remote_server_addr="http://localhost:4444", proxy=Proxy({"proxyType": ProxyType.SYSTEM})
+        )
+        remote_connection = RemoteConnection(client_config=client_config)
+        conn = remote_connection._get_connection_manager()
+        assert isinstance(conn, urllib3.PoolManager)
+        proxy_url = remote_connection._client_config.get_proxy_url()
+        assert proxy_url is None
 
 
 def test_get_proxy_url_none(mock_proxy_settings_missing):