Skip to content

Commit f787770

Browse files
authored
[py][java][rb][ci]: use pinned browsers in CI (#15987)
1 parent 578bc2a commit f787770

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

.github/workflows/ci-java.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
java-version: 17
2424
run: |
2525
fsutil 8dot3name set 0
26-
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
26+
bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
2727
//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest `
2828
//java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest `
2929
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest `
@@ -47,7 +47,7 @@ jobs:
4747
# https://github.com/bazelbuild/rules_jvm_external/issues/1046
4848
java-version: 17
4949
run: |
50-
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
50+
bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
5151
//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest \
5252
//java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest \
5353
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest \
@@ -71,4 +71,4 @@ jobs:
7171
# https://github.com/bazelbuild/rules_jvm_external/issues/1046
7272
java-version: 17
7373
run: |
74-
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
74+
bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote

.github/workflows/ci-python.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ jobs:
8989
os: ${{ matrix.os }}
9090
cache-key: py-browser-${{ matrix.browser }}
9191
run: |
92-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:common-${{ matrix.browser }}-bidi
93-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
92+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi
93+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }}
9494
9595
safari-tests:
9696
name: Browser Tests
@@ -108,4 +108,4 @@ jobs:
108108
os: ${{ matrix.os }}
109109
cache-key: py-browser-${{ matrix.browser }}
110110
run: |
111-
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
111+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }}

.github/workflows/ci-ruby.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
--local_test_jobs 1
8585
--test_size_filters large
8686
--test_tag_filters ${{ matrix.browser }}
87-
${{ matrix.os != 'windows' && '--pin_browsers' || '' }}
87+
--pin_browsers
8888
//rb/spec/...
8989
9090
integration-tests-remote:
@@ -111,5 +111,5 @@ jobs:
111111
--local_test_jobs 1
112112
--test_size_filters large
113113
--test_tag_filters ${{ matrix.browser }}-remote
114-
${{ matrix.os != 'windows' && '--pin_browsers' || '' }}
114+
--pin_browsers
115115
//rb/spec/...

java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import java.util.List;
3030
import org.junit.jupiter.api.AfterEach;
3131
import org.junit.jupiter.api.BeforeEach;
32+
import org.junit.jupiter.api.Disabled;
3233
import org.junit.jupiter.api.Test;
3334
import org.openqa.selenium.By;
3435
import org.openqa.selenium.NoAlertPresentException;
@@ -40,6 +41,7 @@
4041
import org.openqa.selenium.environment.webserver.AppServer;
4142
import org.openqa.selenium.support.ui.WebDriverWait;
4243

44+
@Disabled("https://issues.chromium.org/u/0/issues/425801332")
4345
class FederatedCredentialManagementTest {
4446

4547
private HasFederatedCredentialManagement fedcmDriver;

0 commit comments

Comments
 (0)