Skip to content

Commit f821ea4

Browse files
committed
[dotnet] Improve handling for missing status code in HTTP interception
1 parent 4d99963 commit f821ea4

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

dotnet/src/webdriver/DevTools/v135/V135Network.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
192192
var commandSettings = new FulfillRequestCommandSettings()
193193
{
194194
RequestId = requestData.RequestId,
195-
ResponseCode = responseData.StatusCode,
195+
ResponseCode = responseData.StatusCode.GetValueOrDefault(),
196196
};
197197

198198
if (responseData.Headers.Count > 0 || responseData.CookieHeaders.Count > 0)

dotnet/src/webdriver/DevTools/v136/V136Network.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
192192
var commandSettings = new FulfillRequestCommandSettings()
193193
{
194194
RequestId = requestData.RequestId,
195-
ResponseCode = responseData.StatusCode,
195+
ResponseCode = responseData.StatusCode.GetValueOrDefault(),
196196
};
197197

198198
if (responseData.Headers.Count > 0 || responseData.CookieHeaders.Count > 0)

dotnet/src/webdriver/DevTools/v137/V137Network.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
192192
var commandSettings = new FulfillRequestCommandSettings()
193193
{
194194
RequestId = requestData.RequestId,
195-
ResponseCode = responseData.StatusCode,
195+
ResponseCode = responseData.StatusCode.GetValueOrDefault(),
196196
};
197197

198198
if (responseData.Headers.Count > 0 || responseData.CookieHeaders.Count > 0)
@@ -354,7 +354,7 @@ private void OnFetchRequestPaused(object? sender, Fetch.RequestPausedEventArgs e
354354
RequestId = e.RequestId,
355355
Url = e.Request.Url,
356356
ResourceType = e.ResourceType.ToString(),
357-
StatusCode = e.ResponseStatusCode.GetValueOrDefault(),
357+
StatusCode = e.ResponseStatusCode,
358358
ErrorReason = e.ResponseErrorReason?.ToString()
359359
};
360360

dotnet/src/webdriver/HttpResponseData.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public HttpResponseData()
4747
/// <summary>
4848
/// Gets or sets the numeric status code of the HTTP response.
4949
/// </summary>
50-
public long StatusCode { get; set; }
50+
public long? StatusCode { get; set; }
5151

5252
/// <summary>
5353
/// Gets or sets the body of the HTTP response.

dotnet/src/webdriver/NetworkResponseReceivedEventArgs.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public NetworkResponseReceivedEventArgs(HttpResponseData responseData)
5959
/// <summary>
6060
/// Gets the HTTP status code of the network response.
6161
/// </summary>
62-
public long ResponseStatusCode { get; }
62+
public long? ResponseStatusCode { get; }
6363

6464
/// <summary>
6565
/// Gets the body of the network response.

0 commit comments

Comments
 (0)