Skip to content

Commit f89e2bb

Browse files
committed
get remote tests passing on rbe
1 parent ecd103f commit f89e2bb

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

py/test/selenium/webdriver/firefox/ff_installs_addons_tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
r = Runfiles.Create()
2828
extensions = r.Rlocation("selenium/py/test/extensions")
2929

30+
pytestmark = pytest.mark.xfail_remote(reason="Remote WebDriver does not expose Firefox-specific addon APIs")
31+
3032

3133
@pytest.mark.no_driver_after_test
3234
def test_install_uninstall_signed_addon_xpi(driver, pages):

py/test/selenium/webdriver/firefox/ff_takes_full_page_screenshots_tests.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818
import base64
1919

2020
import filetype
21+
import pytest
22+
23+
pytestmark = pytest.mark.xfail_remote(
24+
reason="Remote WebDriver does not expose Firefox-specific full page screenshot APIs"
25+
)
2126

2227

2328
def test_get_full_page_screenshot_as_base64(driver, pages):

py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
from selenium.webdriver.firefox.firefox_profile import FirefoxProfile
2020

2121

22-
def test_profile_is_used(firefox_options):
22+
def test_profile_is_used(firefox_options, server):
2323
ff_profile = FirefoxProfile()
2424
ff_profile.set_preference("browser.startup.page", "1")
2525
firefox_options.profile = ff_profile
26-
with webdriver.Remote(options=firefox_options) as driver:
26+
server_addr = server.status_url[: -len("/status")]
27+
with webdriver.Remote(command_executor=server_addr, options=firefox_options) as driver:
2728
assert "browser/content/blanktab.html" in driver.current_url

0 commit comments

Comments
 (0)