Skip to content

Commit f96c37f

Browse files
committed
[rb] update guards based on latest geckodriver
1 parent 61e7c70 commit f96c37f

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,22 @@ module WebDriver
3838
expect(driver.find_element(id: 'result').text.strip).to be_empty
3939
end
4040

41-
it 'can send keys with shift pressed' do
42-
driver.navigate.to url_for('javascriptPage.html')
41+
# https://github.com/mozilla/geckodriver/issues/646
42+
not_compliant_on browser: [:firefox, :ff_nightly] do
43+
it 'can send keys with shift pressed' do
44+
driver.navigate.to url_for('javascriptPage.html')
4345

44-
event_input = driver.find_element(id: 'theworks')
45-
keylogger = driver.find_element(id: 'result')
46+
event_input = driver.find_element(id: 'theworks')
47+
keylogger = driver.find_element(id: 'result')
4648

47-
event_input.click
49+
event_input.click
4850

49-
driver.action.key_down(:shift).send_keys('ab').key_up(:shift).perform
50-
wait.until { event_input.attribute(:value).length == 2 }
51+
driver.action.key_down(:shift).send_keys('ab').key_up(:shift).perform
52+
wait.until { event_input.attribute(:value).length == 2 }
5153

52-
expect(event_input.attribute(:value)).to eq('AB')
53-
expect(keylogger.text.strip).to match(/^(focus )?keydown keydown keypress keyup keydown keypress keyup keyup$/)
54+
expect(event_input.attribute(:value)).to eq('AB')
55+
expect(keylogger.text.strip).to match(/^(focus )?keydown keydown keypress keyup keydown keypress keyup keyup$/)
56+
end
5457
end
5558

5659
it 'can press and release modifier keys' do

rb/spec/integration/selenium/webdriver/element_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ module WebDriver
6969
end
7070

7171
# PhantomJS on windows issue: https://github.com/ariya/phantomjs/issues/10993
72-
not_compliant_on browser: [:safari, :edge, :phantomjs] do
72+
# https://github.com/mozilla/geckodriver/issues/644
73+
not_compliant_on browser: [:safari, :edge, :phantomjs, :ff_nightly] do
7374
it 'should handle file uploads' do
7475
driver.navigate.to url_for('formPage.html')
7576

0 commit comments

Comments
 (0)