Skip to content

Commit fa11762

Browse files
committed
Fix specific type hints
1 parent 0bc8c54 commit fa11762

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

py/selenium/webdriver/chrome/webdriver.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
from typing import Optional
19+
1820
from selenium.webdriver.chromium.webdriver import ChromiumDriver
1921
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
2022

@@ -27,8 +29,8 @@ class WebDriver(ChromiumDriver):
2729

2830
def __init__(
2931
self,
30-
options: Options = None,
31-
service: Service = None,
32+
options: Optional[Options] = None,
33+
service: Optional[Service] = None,
3234
keep_alive: bool = True,
3335
) -> None:
3436
"""Creates a new instance of the chrome driver. Starts the service and

py/selenium/webdriver/chromium/webdriver.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
from typing import Optional
19+
1820
from selenium.webdriver.chromium.remote_connection import ChromiumRemoteConnection
1921
from selenium.webdriver.common.driver_finder import DriverFinder
2022
from selenium.webdriver.common.options import ArgOptions
@@ -28,10 +30,10 @@ class ChromiumDriver(RemoteWebDriver):
2830

2931
def __init__(
3032
self,
31-
browser_name: str = None,
32-
vendor_prefix: str = None,
33+
browser_name: Optional[str] = None,
34+
vendor_prefix: Optional[str] = None,
3335
options: ArgOptions = ArgOptions(),
34-
service: Service = None,
36+
service: Optional[Service] = None,
3537
keep_alive: bool = True,
3638
) -> None:
3739
"""Creates a new WebDriver instance of the ChromiumDriver. Starts the

py/selenium/webdriver/common/options.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from abc import ABCMeta
2020
from abc import abstractmethod
2121
from enum import Enum
22+
from typing import List
2223
from typing import Optional
2324

2425
from selenium.common.exceptions import InvalidArgumentException
@@ -497,14 +498,14 @@ class ArgOptions(BaseOptions):
497498

498499
def __init__(self) -> None:
499500
super().__init__()
500-
self._arguments = []
501+
self._arguments: List[str] = []
501502

502503
@property
503504
def arguments(self):
504505
""":Returns: A list of arguments needed for the browser."""
505506
return self._arguments
506507

507-
def add_argument(self, argument) -> None:
508+
def add_argument(self, argument: str) -> None:
508509
"""Adds an argument to the list.
509510
510511
:Args:

py/selenium/webdriver/remote/webdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ def get_pinned_scripts(self) -> List[str]:
497497
"""
498498
return list(self.pinned_scripts)
499499

500-
def execute_script(self, script, *args):
500+
def execute_script(self, script: str, *args):
501501
"""Synchronously Executes JavaScript in the current window/frame.
502502
503503
Parameters:

py/selenium/webdriver/support/event_firing_webdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def back(self) -> None:
8989
def forward(self) -> None:
9090
self._dispatch("navigate_forward", (self._driver,), "forward", ())
9191

92-
def execute_script(self, script, *args):
92+
def execute_script(self, script: str, *args):
9393
unwrapped_args = (script,) + self._unwrap_element_args(args)
9494
return self._dispatch("execute_script", (script, self._driver), "execute_script", unwrapped_args)
9595

0 commit comments

Comments
 (0)