[dotnet] Obsolete constructors on Response that are not conducive to immutability

RenderMichael · RenderMichael · commit faa138db6573 · 2025-01-17T16:27:45.000-05:00
diff --git a/dotnet/src/webdriver/Response.cs b/dotnet/src/webdriver/Response.cs
@@ -42,6 +42,7 @@ public class Response
         /// <summary>
         /// Initializes a new instance of the <see cref="Response"/> class
         /// </summary>
+        [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]
         public Response()
         {
         }
@@ -50,6 +51,7 @@ public Response()
         /// Initializes a new instance of the <see cref="Response"/> class
         /// </summary>
         /// <param name="sessionId">Session ID in use</param>
+        [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]
         public Response(SessionId? sessionId)
         {
             this.SessionId = sessionId?.ToString();

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ public class Response`
`42`	`42`	`/// <summary>`
`43`	`43`	`/// Initializes a new instance of the <see cref="Response"/> class`
`44`	`44`	`/// </summary>`
	`45`	`+ [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]`
`45`	`46`	`public Response()`
`46`	`47`	`{`
`47`	`48`	`}`
`@@ -50,6 +51,7 @@ public Response()`
`50`	`51`	`/// Initializes a new instance of the <see cref="Response"/> class`
`51`	`52`	`/// </summary>`
`52`	`53`	`/// <param name="sessionId">Session ID in use</param>`
	`54`	`+ [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]`
`53`	`55`	`public Response(SessionId? sessionId)`
`54`	`56`	`{`
`55`	`57`	`this.SessionId = sessionId?.ToString();`