Merge branch 'SeleniumHQ:trunk' into py-fix-test-args

Author: cgoldberg

.bazelrc.remote

@@ -31,7 +31,7 @@ build:rbe --disk_cache=
 build:rbe --incompatible_enable_cc_toolchain_resolution
 build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
 test:rbe --test_env=DISPLAY=:99.0
-test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
+test:rbe --test_tag_filters=-skip-rbe,-remote
 
 # Env vars we can hard code
 build:rbe --action_env=HOME=/home/dev

.github/workflows/pre-release.yml

@@ -103,7 +103,7 @@ jobs:
       - name: Commit version updates
         run: git commit -m "bump versions in preparation for release"
       - name: Update changelog
-        run: ./go all:changelog
+        run: ./go all:changelogs
       - name: Commit changelog updates
         run: git commit -m "WIP - rough auto-update of changelog, please edit"
       - name: List untracked files

Rakefile

@@ -166,7 +166,7 @@ end
 desc 'Update Selenium Manager to latest release'
 task :update_manager do |_task, _arguments|
   puts 'Updating Selenium Manager references'
-  Bazel.execute('run', args, '//scripts:selenium_manager')
+  Bazel.execute('run', [], '//scripts:selenium_manager')
 
   @git.add('common/selenium_manager.bzl')
 end
@@ -1181,6 +1181,7 @@ namespace :all do
     Rake::Task['py:lint'].invoke
   end
 
+  # Example: `./go all:prepare 4.31.0 early-stable`
   desc 'Update everything in preparation for a release'
   task :prepare, [:version, :channel] do |_task, arguments|
     version = arguments[:version]
@@ -1206,7 +1207,7 @@ namespace :all do
     Rake::Task['rust:version'].invoke(version)
 
     unless version == 'nightly'
-      Rake::Task['all:changelogs']
+      Rake::Task['all:changelogs'].invoke
 
       major_minor = arguments[:version][/^\d+\.\d+/]
       file = '.github/ISSUE_TEMPLATE/bug-report.yml'

rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb

@@ -74,27 +74,31 @@ class BiDi
           expect(handles).not_to include(window2)
         end
 
-        it 'sets the viewport' do
+        it 'sets the viewport', except: {rbe: true, reason: 'unknown, returns value of 1 instead of 2.0'} do
           browsing_context = described_class.new(bridge)
           browsing_context.set_viewport(width: 800, height: 600, device_pixel_ratio: 2.0)
           expect(driver.execute_script('return [window.innerWidth, window.innerHeight]')).to eq([800, 600])
           expect(driver.execute_script('return window.devicePixelRatio')).to eq(2.0)
         end
 
-        it 'accepts users prompts without text' do
+        it 'accepts users prompts without text',
+           except: {browser: %i[edge chrome],
+                    reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
           browsing_context = described_class.new(bridge)
 
           driver.navigate.to url_for('alerts.html')
           driver.find_element(id: 'alert').click
-          wait.until { driver.switch_to.alert }
+          wait_for_alert
           window = driver.window_handles.first
           browsing_context.handle_user_prompt(window, accept: true)
           wait_for_no_alert
 
           expect(driver.title).to eq('Testing Alerts')
         end
 
-        it 'accepts users prompts with text' do
+        it 'accepts users prompts with text',
+           except: {browser: %i[edge chrome],
+                    reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
           browsing_context = described_class.new(bridge)
           driver.navigate.to url_for('alerts.html')
           driver.find_element(id: 'prompt').click
@@ -106,7 +110,8 @@ class BiDi
           expect(driver.title).to eq('Testing Alerts')
         end
 
-        it 'rejects users prompts' do
+        it 'rejects users prompts', except: {browser: %i[edge chrome],
+                                             reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
           browsing_context = described_class.new(bridge)
           driver.navigate.to url_for('alerts.html')
           driver.find_element(id: 'alert').click

rb/spec/integration/selenium/webdriver/fedcm_spec.rb

@@ -22,7 +22,8 @@
 module Selenium
   module WebDriver
     module FedCM
-      describe FedCM, exclusive: [{ bidi: false, reason: 'Not yet implemented with BiDi' }, { browser: %i[chrome edge] }] do
+      describe FedCM,
+               exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: %i[chrome edge]}] do
         let(:dialog) { driver.fedcm_dialog }
 
         before { driver.get url_for('fedcm/fedcm.html') }
@@ -66,8 +67,8 @@ module FedCM
             expect(dialog.select_account(1)).to be_nil
           end
 
-          it 'clicks the dialog', except: { browser: %i[chrome edge],
-                                            reason: "error: 'Use another account' not supported for this IDP" } do
+          it 'clicks the dialog', except: {browser: %i[chrome edge],
+                                           reason: "error: 'Use another account' not supported for this IDP"} do
             expect(dialog.click).to be_nil
           end