Skip to content

Commit ff3575b

Browse files
authored
Merge branch 'trunk' into add-jspecify-annotations-by
2 parents 29ccda6 + 875f0a6 commit ff3575b

File tree

260 files changed

+4270
-2059
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

260 files changed

+4270
-2059
lines changed

.github/workflows/bazel.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
node-version: ${{ inputs.node-version }}
117117
- name: Setup Bazel with caching
118118
if: inputs.caching
119-
uses: bazel-contrib/setup-bazel@0.8.5
119+
uses: bazel-contrib/setup-bazel@0.9.1
120120
with:
121121
bazelisk-cache: true
122122
bazelrc: common --color=yes
@@ -130,7 +130,7 @@ jobs:
130130
repository-cache: true
131131
- name: Setup Bazel without caching
132132
if: inputs.caching == false
133-
uses: bazel-contrib/setup-bazel@0.8.5
133+
uses: bazel-contrib/setup-bazel@0.9.1
134134
with:
135135
bazelrc: common --color=yes
136136
- name: Setup Fluxbox and Xvfb

.github/workflows/ci-python.yml

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,35 @@ jobs:
100100
fail-fast: false
101101
matrix:
102102
include:
103-
- browser: safari
104-
os: macos
105103
- browser: chrome
104+
os: ubuntu
105+
- browser: edge
106+
os: ubuntu
107+
- browser: firefox
108+
os: ubuntu
109+
with:
110+
name: Integration Tests (${{ matrix.browser }}, ${{ matrix.os }})
111+
browser: ${{ matrix.browser }}
112+
os: ${{ matrix.os }}
113+
cache-key: py-browser-${{ matrix.browser }}
114+
run: |
115+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:common-${{ matrix.browser }}-bidi
116+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
117+
118+
safari-tests:
119+
name: Browser Tests
120+
needs: build
121+
uses: ./.github/workflows/bazel.yml
122+
strategy:
123+
fail-fast: false
124+
matrix:
125+
include:
126+
- browser: safari
106127
os: macos
107128
with:
108129
name: Integration Tests (${{ matrix.browser }}, ${{ matrix.os }})
109130
browser: ${{ matrix.browser }}
110131
os: ${{ matrix.os }}
111132
cache-key: py-browser-${{ matrix.browser }}
112-
run: bazel test --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
133+
run: |
134+
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
with:
2222
fetch-depth: 50
2323
- name: Setup Bazel
24-
uses: bazel-contrib/setup-bazel@0.8.5
24+
uses: bazel-contrib/setup-bazel@0.9.1
2525
with:
2626
bazelisk-cache: true
2727
cache-version: 2

.skipped-tests

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
-//py:test-chrome-test/selenium/webdriver/chrome/chrome_launcher_tests.py
3232
-//py:test-chrome-test/selenium/webdriver/chrome/chrome_service_tests.py
3333
-//py:test-chrome-test/selenium/webdriver/chrome/proxy_tests.py
34+
-//py:test-edge-test/selenium/webdriver/edge/edge_launcher_tests.py
35+
-//py:test-edge-test/selenium/webdriver/edge/edge_service_tests.py
3436
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome
3537
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome-bidi
3638
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome-remote

AUTHORS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ Andrei <[email protected]>
6868
Andrei Botalov <[email protected]>
6969
Andrei Rusu <[email protected]>
7070
Andrei Solntsev <[email protected]>
71+
Andrew Nesbitt <[email protected]>
7172
Andrey Botalov <[email protected]>
7273
Andrii Rohovets <[email protected]>
7374
Andy Duncan <[email protected]>
@@ -334,6 +335,7 @@ Harshit Agrawal <[email protected]>
334335
335336
Haw-bin Chai <[email protected]>
336337
hectorhon <[email protected]>
338+
337339
338340
helen3141 <[email protected]>
339341
Henrik Skupin <[email protected]>
@@ -458,6 +460,7 @@ Jonathan Lipps <[email protected]>
458460
Jonathon Kereliuk <[email protected]>
459461
Jongkuen Hong <[email protected]>
460462
Jordan Mace <[email protected]>
463+
Jose D. Gomez R. <[email protected]>
461464
462465
Josh Goldberg <[email protected]>
463466
Joshua Bruning <[email protected]>
@@ -633,6 +636,7 @@ MustafaAgamy <[email protected]>
633636
Muthu Kannan
634637
MWschutte <[email protected]>
635638
639+
Natalia Pozhidaeva <[email protected]>
636640
Nate Lowry <[email protected]>
637641
Nathan Isom <[email protected]>
638642
native-api <[email protected]>

MODULE.bazel

Lines changed: 36 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ bazel_dep(name = "rules_cc", version = "0.0.9", dev_dependency = True)
1919

2020
bazel_dep(name = "rules_dotnet", version = "0.16.1")
2121
bazel_dep(name = "rules_java", version = "7.11.1")
22-
bazel_dep(name = "rules_jvm_external", version = "6.3")
22+
bazel_dep(name = "rules_jvm_external", version = "6.6")
2323
bazel_dep(name = "rules_nodejs", version = "6.3.0")
2424
bazel_dep(name = "rules_oci", version = "1.7.6")
2525
bazel_dep(name = "rules_pkg", version = "0.10.1")
@@ -177,52 +177,57 @@ maven.install(
177177
"com.google.auto:auto-common:1.2.2",
178178
"com.google.auto.service:auto-service:1.1.1",
179179
"com.google.auto.service:auto-service-annotations:1.1.1",
180-
"com.google.googlejavaformat:google-java-format:jar:1.24.0",
180+
"com.google.googlejavaformat:google-java-format:jar:1.25.0",
181181
"com.graphql-java:graphql-java:22.3",
182182
"dev.failsafe:failsafe:3.3.2",
183183
"io.grpc:grpc-context:1.68.1",
184-
"io.lettuce:lettuce-core:6.4.0.RELEASE",
185-
"io.netty:netty-buffer:4.1.114.Final",
186-
"io.netty:netty-codec-http:4.1.114.Final",
187-
"io.netty:netty-codec-http2:4.1.114.Final",
188-
"io.netty:netty-common:4.1.114.Final",
189-
"io.netty:netty-handler:4.1.114.Final",
190-
"io.netty:netty-handler-proxy:4.1.114.Final",
191-
"io.netty:netty-transport:4.1.114.Final",
192-
"io.opentelemetry:opentelemetry-api:1.43.0",
193-
"io.opentelemetry:opentelemetry-context:1.43.0",
194-
"io.opentelemetry:opentelemetry-exporter-logging:1.43.0",
195-
"io.opentelemetry:opentelemetry-sdk:1.43.0",
196-
"io.opentelemetry:opentelemetry-sdk-common:1.43.0",
197-
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:1.43.0",
198-
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:1.43.0",
199-
"io.opentelemetry:opentelemetry-sdk-testing:1.43.0",
200-
"io.opentelemetry:opentelemetry-sdk-trace:1.43.0",
201-
"io.opentelemetry.semconv:opentelemetry-semconv:1.25.0-alpha",
184+
"io.lettuce:lettuce-core:6.5.0.RELEASE",
185+
"io.netty:netty-buffer",
186+
"io.netty:netty-codec-http",
187+
"io.netty:netty-codec-http2",
188+
"io.netty:netty-common",
189+
"io.netty:netty-handler",
190+
"io.netty:netty-handler-proxy",
191+
"io.netty:netty-transport",
192+
"io.opentelemetry:opentelemetry-api",
193+
"io.opentelemetry:opentelemetry-context",
194+
"io.opentelemetry:opentelemetry-exporter-logging",
195+
"io.opentelemetry:opentelemetry-sdk",
196+
"io.opentelemetry:opentelemetry-sdk-common",
197+
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure",
198+
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi",
199+
"io.opentelemetry:opentelemetry-sdk-testing",
200+
"io.opentelemetry:opentelemetry-sdk-trace",
201+
"io.opentelemetry.semconv:opentelemetry-semconv:1.28.0-alpha",
202202
"it.ozimov:embedded-redis:0.7.3",
203203
"net.bytebuddy:byte-buddy:1.15.10",
204-
"org.htmlunit:htmlunit-core-js:4.5.0",
204+
"org.htmlunit:htmlunit-core-js:4.6.0",
205205
"org.apache.commons:commons-exec:1.4.0",
206206
"org.apache.logging.log4j:log4j-core:2.24.1",
207207
"org.assertj:assertj-core:3.26.3",
208-
"org.bouncycastle:bcpkix-jdk18on:1.78.1",
208+
"org.bouncycastle:bcpkix-jdk18on:1.79",
209209
"org.eclipse.mylyn.github:org.eclipse.egit.github.core:2.1.5",
210210
"org.hsqldb:hsqldb:2.7.4",
211211
"org.jspecify:jspecify:1.0.0",
212-
"org.junit.jupiter:junit-jupiter-api:5.11.3",
213-
"org.junit.jupiter:junit-jupiter-engine:5.11.3",
214-
"org.junit.jupiter:junit-jupiter-params:5.11.3",
215-
"org.junit.platform:junit-platform-launcher:1.11.3",
216-
"org.junit.platform:junit-platform-reporting:1.11.3",
217-
"org.junit.platform:junit-platform-commons:1.11.3",
218-
"org.junit.platform:junit-platform-engine:1.11.3",
212+
"org.junit.jupiter:junit-jupiter-api",
213+
"org.junit.jupiter:junit-jupiter-engine",
214+
"org.junit.jupiter:junit-jupiter-params",
215+
"org.junit.platform:junit-platform-launcher",
216+
"org.junit.platform:junit-platform-reporting",
217+
"org.junit.platform:junit-platform-commons",
218+
"org.junit.platform:junit-platform-engine",
219219
"org.mockito:mockito-core:5.14.2",
220-
"org.redisson:redisson:3.37.0",
220+
"org.redisson:redisson:3.39.0",
221221
"org.slf4j:slf4j-api:2.0.16",
222222
"org.slf4j:slf4j-jdk14:2.0.16",
223223
"org.tomlj:tomlj:1.1.1",
224224
"org.zeromq:jeromq:0.6.0",
225225
],
226+
boms = [
227+
"io.opentelemetry:opentelemetry-bom:1.44.1",
228+
"io.netty:netty-bom:4.1.115.Final",
229+
"org.junit:junit-bom:5.11.3",
230+
],
226231
excluded_artifacts = [
227232
"org.hamcrest:hamcrest-all", # Replaced by hamcrest 2
228233
"org.hamcrest:hamcrest-core",
@@ -235,6 +240,7 @@ maven.install(
235240
repositories = [
236241
"https://repo1.maven.org/maven2",
237242
],
243+
resolver = "maven",
238244
strict_visibility = True,
239245
)
240246
use_repo(maven, "maven", "unpinned_maven")

README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,18 @@ Run unit tests with:
317317
bazel test //py:unit
318318
```
319319

320+
To run common tests with a specific browser:
321+
322+
```sh
323+
bazel test //py:common-<browsername>
324+
```
325+
326+
To run common tests with a specific browser (include BiDi tests):
327+
328+
```sh
329+
bazel test //py:common-<browsername>-bidi
330+
```
331+
320332
To run tests with a specific browser:
321333

322334
```sh

Rakefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ task '//java/test/org/openqa/selenium/environment/webserver:webserver:uber' => [
9797
JAVA_RELEASE_TARGETS = %w[
9898
//java/src/org/openqa/selenium/chrome:chrome.publish
9999
//java/src/org/openqa/selenium/chromium:chromium.publish
100-
//java/src/org/openqa/selenium/devtools/v128:v128.publish
100+
//java/src/org/openqa/selenium/devtools/v131:v131.publish
101101
//java/src/org/openqa/selenium/devtools/v129:v129.publish
102102
//java/src/org/openqa/selenium/devtools/v130:v130.publish
103103
//java/src/org/openqa/selenium/devtools/v85:v85.publish
@@ -582,10 +582,11 @@ namespace :py do
582582
desc 'Update Python version'
583583
task :version, [:version] do |_task, arguments|
584584
old_version = python_version
585-
nightly = ".dev#{Time.now.strftime('%Y%m%d%H%M')}"
585+
nightly = ".#{Time.now.strftime('%Y%m%d%H%M')}"
586586
new_version = updated_version(old_version, arguments[:version], nightly)
587587

588588
['py/setup.py',
589+
'py/pyproject.toml',
589590
'py/BUILD.bazel',
590591
'py/selenium/__init__.py',
591592
'py/selenium/webdriver/__init__.py',
@@ -1138,7 +1139,7 @@ def updated_version(current, desired = nil, nightly = nil)
11381139
desired.split('.').tap { |v| v << 0 while v.size < 3 }.join('.')
11391140
elsif current.split(/\.|-/).size > 3
11401141
# if current version is already nightly, just need to bump it; this will be noop for some languages
1141-
pattern = /-?\.?(nightly|SNAPSHOT|dev)\d*$/
1142+
pattern = /-?\.?(nightly|SNAPSHOT|dev|\d{12})\d*$/
11421143
current.gsub(pattern, nightly)
11431144
elsif current.split(/\.|-/).size == 3
11441145
# if current version is not nightly, need to bump the version and make nightly

0 commit comments

Comments
 (0)