Merge branch 'trunk' into download_end

Author: Delta456

dotnet/src/webdriver/DriverService.cs

@@ -170,6 +170,14 @@ public int ProcessId
     /// </summary>
     protected virtual bool HasShutdown => true;
 
+    /// <summary>
+    /// Gets a value indicating whether process redirection is enforced regardless of other settings.
+    /// </summary>
+    /// <remarks>Set this property to <see langword="true"/> to force all process output and error streams to
+    /// be redirected, even if redirection is not required by default behavior. This can be useful in scenarios where
+    /// capturing process output is necessary for logging or analysis.</remarks>
+    protected virtual internal bool EnableProcessRedirection { get; } = false;
+
     /// <summary>
     /// Gets a value indicating whether the service is responding to HTTP requests.
     /// </summary>
@@ -249,16 +257,23 @@ public void Start()
         this.driverServiceProcess.StartInfo.RedirectStandardOutput = true;
         this.driverServiceProcess.StartInfo.RedirectStandardError = true;
 
-        this.driverServiceProcess.OutputDataReceived += this.OnDriverProcessDataReceived;
-        this.driverServiceProcess.ErrorDataReceived += this.OnDriverProcessDataReceived;
+        if (this.EnableProcessRedirection)
+        {
+            this.driverServiceProcess.OutputDataReceived += this.OnDriverProcessDataReceived;
+            this.driverServiceProcess.ErrorDataReceived += this.OnDriverProcessDataReceived;
+        }
 
         DriverProcessStartingEventArgs eventArgs = new DriverProcessStartingEventArgs(this.driverServiceProcess.StartInfo);
         this.OnDriverProcessStarting(eventArgs);
 
-        // Important: Start the process and immediately begin reading the output and error streams to avoid IO deadlocks.
         this.driverServiceProcess.Start();
-        this.driverServiceProcess.BeginOutputReadLine();
-        this.driverServiceProcess.BeginErrorReadLine();
+
+        if (this.EnableProcessRedirection)
+        {
+            // Important: Start the process and immediately begin reading the output and error streams to avoid IO deadlocks.
+            this.driverServiceProcess.BeginOutputReadLine();
+            this.driverServiceProcess.BeginErrorReadLine();
+        }
 
         bool serviceAvailable = this.WaitForServiceInitialization();
 
@@ -289,7 +304,7 @@ protected virtual void Dispose(bool disposing)
             {
                 this.Stop();
 
-                if (this.driverServiceProcess is not null)
+                if (EnableProcessRedirection && this.driverServiceProcess is not null)
                 {
                     this.driverServiceProcess.OutputDataReceived -= this.OnDriverProcessDataReceived;
                     this.driverServiceProcess.ErrorDataReceived -= this.OnDriverProcessDataReceived;
@@ -335,13 +350,7 @@ protected virtual void OnDriverProcessStarted(DriverProcessStartedEventArgs even
     /// <param name="args">The data received event arguments.</param>
     protected virtual void OnDriverProcessDataReceived(object sender, DataReceivedEventArgs args)
     {
-        if (string.IsNullOrEmpty(args.Data))
-            return;
 
-        if (_logger.IsEnabled(LogEventLevel.Trace))
-        {
-            _logger.Trace(args.Data);
-        }
     }
 
     /// <summary>

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -222,6 +222,11 @@ protected override string CommandLineArguments
         }
     }
 
+    /// <summary>
+    /// Gets a value indicating whether process output redirection is required.
+    /// </summary>
+    protected internal override bool EnableProcessRedirection => LogPath is not null;
+
     /// <summary>
     /// Called when the driver process is starting. This method sets up log file writing if a log path is specified.
     /// </summary>