-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] use common annotations in BiDi tests #14702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
Here are some number for this PR, from my local trunk: Elapsed time: 2211.549s, Critical Path: 411.28s |
CI Failure Feedback 🧐
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much @joerg1985!
User description
Motivation and Context
This PR will use the common annotations in the BiDi tests to ensure the driver is restarted.
Additionally the provided NettyAppServer is used and not started before each test.
On my local system it takes ~500ms to start the NettyAppServer, this is how i stumbled into this.
I will improve the startup of the NettyAppServer as soon as this is merged.
@pujagani could you hava a look at this?
Types of changes
Checklist
PR Type
enhancement, tests
Description
@BeforeEachand@AfterEachannotations, replacing them with@NeedsFreshDriverto ensure a fresh driver for each test.serverwithappServerin test classes to standardize server usage.@BeforeAlland@AfterAllannotations inRemoteWebDriverBiDiTestfor server lifecycle management.Changes walkthrough 📝
16 files
BiDiTest.java
Refactor BiDiTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/BiDiTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.BrowserCommandsTest.java
Refactor BrowserCommandsTest to use common annotationsjava/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.BrowsingContextInspectorTest.java
Refactor BrowsingContextInspectorTest to use common annotationsjava/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.BrowsingContextTest.java
Refactor BrowsingContextTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.LocateNodesTest.java
Refactor LocateNodesTest to use common annotationsjava/test/org/openqa/selenium/bidi/browsingcontext/LocateNodesTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.ReleaseCommandTest.java
Refactor ReleaseCommandTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/input/ReleaseCommandTest.java
@BeforeEachannotation.@NeedsFreshDriverannotation to test methods.serverwithappServer.SetFilesCommandTest.java
Refactor SetFilesCommandTest to use common annotationsjava/test/org/openqa/selenium/bidi/input/SetFilesCommandTest.java
@BeforeEachannotation.@NeedsFreshDriverannotation to test methods.LogInspectorTest.java
Refactor LogInspectorTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/log/LogInspectorTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.AddInterceptParametersTest.java
Refactor AddInterceptParametersTest to use common annotationsjava/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.NetworkCommandsTest.java
Refactor NetworkCommandsTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.NetworkEventsTest.java
Refactor NetworkEventsTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.CallFunctionParameterTest.java
Refactor CallFunctionParameterTest to use common annotationsjava/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.EvaluateParametersTest.java
Refactor EvaluateParametersTest to use common annotationsjava/test/org/openqa/selenium/bidi/script/EvaluateParametersTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.ScriptCommandsTest.java
Refactor ScriptCommandsTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/script/ScriptCommandsTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.ScriptEventsTest.java
Refactor ScriptEventsTest to use common annotations and appServerjava/test/org/openqa/selenium/bidi/script/ScriptEventsTest.java
@BeforeEachand@AfterEachannotations.@NeedsFreshDriverannotation to test methods.serverwithappServer.RemoteWebDriverBiDiTest.java
Refactor RemoteWebDriverBiDiTest for server lifecycle managementjava/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java
@BeforeAlland@AfterAllannotations for server setup andteardown.
@BeforeEachannotation for server setup.