[🐛 Bug]: [dotnet] Null check on `ISupportsPrint.Print` is different from parameter name

[RenderMichael]

What happened?

ISupportsPrint.Print(options: null); // <- throws parameter 'printOptions' is null

How can we reproduce the issue?

WebDriver driver = new ChromeDriver();
((ISupportsPrint)driver).Print(options: null); // <- throws parameter 'printOptions' is null

Relevant log output

N/A

Operating System

Windows 11

Selenium version

.NET nightly

What are the browser(s) and version(s) where you see this issue?

N/A

What are the browser driver(s) and version(s) where you see this issue?

N/A

Are you using Selenium Grid?

No

[github-actions]

@RenderMichael, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[RenderMichael]

This is caused by a mismatch in parameter names between the interface ISupportsPrint.Print(options) and the implementing type WebDriver.Print(printOptions). This is considered incorrect (for reasons such as this one) but fixing it directly is a breaking change. We can do something like this:

class WebDriver
{
    void ISupportsPrint.Print(PrintOptions options)
    {
        if (options is null)
        {
            throw new ArgumentNullException(nameof(options));
        }

        Print(printOptions: options);
    }
}

This would throw an exception with the right parameter name, whether a user goes through the interface or the type. We can factor out the double null-check if that's desired.

Edit: Default Interface Methods are not supported on .NET Standard 2.0, so this could only be applied to .NET 8.

[nvborisenko]

Let's fix it, selenium doesn't follow SemVer. To negotiate this "minor" breaking change we will reflect this change in Blog post (automatically will be included).

If we create a commit something like [dotnet] [breaking change] printOptions parameter name in Print method renamed to options, then it is enough. And, of course, reflect it in CHANGELOG when releasing.

[Delta456]

This PR can be closed as #14773 is merged which fixes it.

[github-actions]

This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days.