Drop bindir from .gemspec
#14933
Closed
Drop bindir from .gemspec
#14933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directive has no effect without specifying `executables`. And the shipped executables do not qualify to be listed, because they are not "executable Ruby files" [[1]]. Moreover they are located in nested directories. [1]: https://github.com/rubygems/guides/blob/4357756b8cf9bef92b90e717306b5bf9c332d9f6/specification-reference.md?plain=1#L387
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Just FTR, I don't think I am allowed to sign CLA, therefore do whatever you have to do with this contribution ... |
|
We can't merge it without CLA, so I'll have to close this PR. I agree that in current form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This directive has no effect without specifying
executables. And the shipped executables do not qualify to be listed, because they are not "executable Ruby files" [1]. Moreover they are located in nested directories.PR Type
Enhancement
Description
bindirdirective from selenium-webdriver gemspec since it has no effect without specifyingexecutablesChanges walkthrough 📝
selenium-webdriver.gemspec
Remove unused bindir directive from gemspec configurationrb/selenium-webdriver.gemspec
bindirdirective from gemspec as it has no effect withoutexecutablesdirectories