-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Annotate nullability on SendingRemoteHttpRequestEventArgs
#15148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Annotate nullability on SendingRemoteHttpRequestEventArgs
#15148
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
dotnet/src/webdriver/Remote/SendingRemoteHttpRequestEventArgs.cs
Outdated
Show resolved
Hide resolved
…eleniumHQ#15148) * [dotnet] Annotate nullability on `SendingRemoteHttpRequestEventArgs` * Do not consume our public-facing HTTP request event args body
…eleniumHQ#15148) * [dotnet] Annotate nullability on `SendingRemoteHttpRequestEventArgs` * Do not consume our public-facing HTTP request event args body
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Annotate nullability on
SendingRemoteHttpRequestEventArgsMotivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Annotated nullability for
SendingRemoteHttpRequestEventArgsclass.Replaced mutable fields with read-only properties for immutability.
Added null checks and exceptions for constructor and method parameters.
Improved code readability and safety with
#nullable enable.Changes walkthrough 📝
SendingRemoteHttpRequestEventArgs.cs
Annotated nullability and improved immutability.dotnet/src/webdriver/Remote/SendingRemoteHttpRequestEventArgs.cs
#nullable enable.