-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[javascript] Support for tap events based on touch #15260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@iOrangeTea could you please share some context about this PR and sign the CLA? |
|
Hello @diemol, I have already signed the CLA. Thanks for your remind. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Added support for tap events in Selenium's JavaScript atoms.
Introduced
tapfunction inwebdriver.atoms.inputsfor touchscreen interactions.Updated
BUILD.bazelto include a new closure fragment fortap.Modified
events.jsto handleinitTouchEventdifferently for iOS.Changes walkthrough 📝
events.js
Update `initTouchEvent` handling for iOS compatibilityjavascript/atoms/events.js
initTouchEventhandling for non-iOS devices.initTouchEvent.inputs.js
Export `tap` function in `webdriver.atoms.inputs`javascript/webdriver/atoms/exports/inputs.js
tapfunction for external use.action.js
Add `tap` function to inject tap actionsjavascript/webdriver/atoms/inject/action.js
tapfunction to inject tap actions on elements.tapfunction with JSDoc comments.inputs.js
Add `tap` function for touchscreen interactionsjavascript/webdriver/atoms/inputs.js
tapfunction for touchscreen interactions.bot.Touchscreenfor touch-based actions.BUILD.bazel
Add closure fragment for `tap` in BUILD.bazeljavascript/webdriver/atoms/inject/BUILD.bazel
tapfunction.tapto theactionmodule dependencies.