[🚀 Feature]: [dotnet] Expose HttpClient initialization in HttpCommandExecutor to make it possible for overriding

[nvborisenko]

Feature and motivation

HttpCommandExecutor entirely closed for any overriding to create HttpClient:

selenium/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs

Line 224 in 6836d0a

private HttpClient CreateHttpClient()

It will be good to make it protected virtual. Proposed API:

protected virtual HttpClientHandler CreateHttpClientHandler()
protected virtual HttpClient CreateHttpClient()

It also exposes initialization of HttpClientHandler to make it possible to customize it, like ignoring certificate validation (appium/dotnet-client#455).

Usage example

class MyHttpCommandExecutor : HttpCommandExecutor
{
  override CreateHttpClientHandler()
  {
    var handler = base.CreateHttpClientHandler();
    handler.SomeProperty = "abc";
    return handler;
  }
}

[github-actions]

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[nvborisenko]

It will be amazing to implement it and include into upcoming release for our Appium friends. @RenderMichael do you have any objections about proposed API?

[RenderMichael]

I think the goal is a good one.

An alternative API would be to modify the existing HttpClient and HttpClientHandler:

public class MyHttpCommandExecutor : HttpCommandExecutor
{
  protected override void ModifyHttpClientHandler(HttpClientHandler handler)
  {
    httpHandler.ServerCertificateCustomValidationCallback = 
        HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
  }

  protected override void ModifyHttpClient(HttpClient client)
  {
    // anything else here
  }
}

This helps ensure nobody misses calling var handler = base.CreateHttpClientHandler();, prevents any null returns, and leaves things in a safer state overall.

[nvborisenko]

ModifyHttpClientHandler wants to be an Action, like ConfigureServices(container). I prefer more Create*, then user is able to return new * he wants, not only modified. So more flexibility for advanced users.

[nvborisenko]

Done, thanks team.

[github-actions]

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.