[🐛 Bug]: Incorrect NRT annotations for CreateDefaultService APIs

[MaceWindu]

What happened?

Following API (at least for Edge and Firefox drivers, but I suspect others too) allow user to pass optional driver path (and executable name) or at least doesn't assert it is specified:

https://github.com/SeleniumHQ/selenium/blob/selenium-4.29.0/dotnet/src/webdriver/Edge/EdgeDriverService.cs#L99

https://github.com/SeleniumHQ/selenium/blob/selenium-4.29.0/dotnet/src/webdriver/Firefox/FirefoxDriverService.cs#L219

With NRT annotations enabled in 4.29.0 they now generate build error when nullable parameter passed.

How can we reproduce the issue?

class Test
{
    public DriverService Create(string? optionalPathToDriver, string? exeName, bool isEdge)
    {
        // Possible null reference argument for parameter 'driverPath' in 'FirefoxDriverService FirefoxDriverService.CreateDefaultService(string driverPath)'.
        // Possible null reference argument for parameter 'driverPath' in 'EdgeDriverService EdgeDriverService.CreateDefaultService(string driverPath, string driverExecutableFileName)'.
        return isEdge
            ? EdgeDriverService.CreateDefaultService(optionalPathToDriver, exeName)
            : FirefoxDriverService.CreateDefaultService(optionalPathToDriver, exeName);
    }
}

Relevant log output

irrelevant

Operating System

irrelevant

Selenium version

4.29.0 [.NET]

What are the browser(s) and version(s) where you see this issue?

irrelevant

What are the browser driver(s) and version(s) where you see this issue?

irrelevant

Are you using Selenium Grid?

No response

[github-actions]

@MaceWindu, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[nvborisenko]

That's true, params can be nullable. @RenderMichael FYI

[RenderMichael]

It works perfectly well to pass in null to any of the CreateDefaultService methods (you're correct, this affects all browser services). I will submit a fix.

[RenderMichael]

This bug has been fixed and will be a part of the 4.30 release. As a workaround, you can suppress the maybe-null warnings

return isEdge
            ? EdgeDriverService.CreateDefaultService(optionalPathToDriver!, exeName!)
            : FirefoxDriverService.CreateDefaultService(optionalPathToDriver!, exeName!);

Thank you

[github-actions]

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.