-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[js][bidi]: fix chrome and firefox test for CI RBE #15405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
Thanks for looking into this and getting it passing! |
|
This seems like a regression. The spec seems to indicate it should be null: |
|
Reading the spec, we see that in step 6 |
fix chrome and firefox test for CI RBE
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Fix chrome and firefox test for CI RBE for JS.
Resolves the CI failures
Types of changes
Checklist
PR Type
Bug fix
Description
Fixed test assertion for
childrenin browsing context inspector.Ensured
childrenis validated as an empty array.Improved robustness of CI tests for Chrome and Firefox.
Changes walkthrough 📝
browsingcontext_inspector_test.js
Fix and enhance browsing context inspector testjavascript/node/selenium-webdriver/test/bidi/browsingcontext_inspector_test.js
childrento check for an empty array.children.