Added getValue() method

[OmkarGharat]

User description

Title:

Added getValue() method to WebElement

Motivation and Context:

• This PR adds the getValue() method to WebElement, allowing users to retrieve the computed accessible name of an element.
• The method aligns with the [W3C WebDriver Specification](https://www.w3.org/TR/webdriver/#get-computed-label).
• This enhancement improves accessibility testing and provides better programmatic access to an element’s computed label.

Types of changes:

• New feature (non-breaking change which adds functionality)

Checklist:

• I have read the [contributing](https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md) document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

👉 Reviewers: Please let me know if any modifications are needed! 🚀

---

PR Type

Enhancement

---

Description

• Added getValue() method to WebElement interface for retrieving element values.

• Implemented getValue() in RemoteWebElement to fetch the value attribute.

• Enhanced accessibility and programmatic access to element properties.

---

Changes walkthrough 📝

Relevant files

Enhancement

WebElement.java Added `getValue()` method to `WebElement` interface            java/src/org/openqa/selenium/WebElement.java Introduced getValue() method to retrieve the value attribute. Added detailed documentation for the new method. Improved accessibility and usability of the WebElement interface. +372/-291 RemoteWebElement.java Implemented `getValue()` in `RemoteWebElement`                      java/src/org/openqa/selenium/remote/RemoteWebElement.java Implemented getValue() method to return the value attribute. Utilized getDomProperty("value") for fetching the value. +5/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[CLAassistant]

All committers have signed the CLA.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Implementation Concern The getValue() method implementation uses getDomProperty("value") which might not be supported by all browsers or WebDriver implementations. Consider adding error handling or fallback to getAttribute("value") for better compatibility. public String getValue() { return getDomProperty("value"); Documentation Mismatch The JavaDoc for getValue() mentions it's similar to getAttribute("value"), but the implementation in RemoteWebElement uses getDomProperty("value"). This inconsistency should be clarified in the documentation. * Gets the value attribute of the element. * * <p> * This method retrieves the current value of the element, similar to * {@code getAttribute("value")}. It is useful for getting text entered in * input fields or selected values in dropdowns. * * <p> * See <a href="https://www.w3.org/TR/webdriver/#get-element-attribute">W3C * WebDriver specification</a> * for more details. * * @return the value of the element as a string. */

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add nullable annotation The method declaration should specify that it may return null when the value attribute is not present, consistent with other attribute getter methods in the interface. java/src/org/openqa/selenium/WebElement.java [405-420] /** * Gets the value attribute of the element. * * <p> * This method retrieves the current value of the element, similar to * {@code getAttribute("value")}. It is useful for getting text entered in * input fields or selected values in dropdowns. * * <p> * See <a href="https://www.w3.org/TR/webdriver/#get-element-attribute">W3C * WebDriver specification</a> * for more details. * - * @return the value of the element as a string. + * @return the value of the element as a string, or null if the value is not set. */ -String getValue(); +@Nullable String getValue(); Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that the getValue() method should be consistent with other attribute getter methods in the interface by including the @nullable annotation. This is important for API consistency and proper null handling by consumers of the interface, as the value attribute might not be present for all elements.	Medium
More

[titusfortner]

Thank you for your contribution!

The endpoint: /session/{session id}/element/{element id}/computedlabel

is already implemented by getAccessibleName()
https://github.com/SeleniumHQ/selenium/blob/123bb677/java/src/org/openqa/selenium/remote/RemoteWebElement.java#L158-L160

While I can see the value of having a convenience method to get the value property in some use cases, it is easy to add in your own framework, and we're trying not to add simple wrapping methods to these already large classes.

I'm going to close this, but thank you again for submitting a PR.

[OmkarGharat]

Hi Thank you for reviewing my PR and providing valuable feedback. I understand that getAccessibleName() already implements the required functionality, and adding a wrapper method may not be ideal due to class size considerations. I appreciate the insight and will keep this in mind for future contributions. However, I was wondering—would you suggest an alternate way to make value retrieval more convenient without adding an extra method? I'd love to explore if there's a more efficient approach. Thanks again for your time and guidance! Best regards, Omkar

…

On Sat, 22 Mar 2025 at 08:57, Titus Fortner ***@***.***> wrote: Thank you for your contribution! The endpoint: /session/{session id}/element/{element id}/computedlabel is already implemented by getAccessibleName() https://github.com/SeleniumHQ/selenium/blob/123bb677/java/src/org/openqa/selenium/remote/RemoteWebElement.java#L158-L160 While I can see the value of having a convenience method to get the value property in some use cases, it is easy to add in your own framework, and we're trying not to add simple wrapping methods to these already large classes. I'm going to close this, but thank you again for submitting a PR. — Reply to this email directly, view it on GitHub <#15480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT23NNCMAHLHZFXEWUBYKG32VTKB5AVCNFSM6AAAAABZRHDWUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBUHE2DKOBTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: titusfortner]*titusfortner* left a comment (SeleniumHQ/selenium#15480) <#15480 (comment)> Thank you for your contribution! The endpoint: /session/{session id}/element/{element id}/computedlabel is already implemented by getAccessibleName() https://github.com/SeleniumHQ/selenium/blob/123bb677/java/src/org/openqa/selenium/remote/RemoteWebElement.java#L158-L160 While I can see the value of having a convenience method to get the value property in some use cases, it is easy to add in your own framework, and we're trying not to add simple wrapping methods to these already large classes. I'm going to close this, but thank you again for submitting a PR. — Reply to this email directly, view it on GitHub <#15480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT23NNCMAHLHZFXEWUBYKG32VTKB5AVCNFSM6AAAAABZRHDWUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBUHE2DKOBTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[titusfortner]

This is an example of how I wrap the WebElement from a workshop I teach:
https://github.com/titusfortner/craft_framework/blob/test_fest/src/test/java/com/titusfortner/craft_framework/elements/Element.java

I don't love all of this code, but it is useful for demonstration purposes. If I found myself doing a lot of getDomProperty("value") calls, I could see adding a convenience method to that class.,