Skip to content

Conversation

@cdce8p
Copy link

@cdce8p cdce8p commented Mar 23, 2025

User description

Motivation and Context

PEP 639 added the support for SPDX license expressions in the project metadata. Setuptools v77 just added support for it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Updated project metadata to use SPDX license expressions.

  • Increased setuptools version requirement to >=77.0.

  • Removed redundant license classifier from project metadata.


Changes walkthrough 📝

Relevant files
Enhancement
pyproject.toml
Update project metadata for SPDX and setuptools                   

py/pyproject.toml

  • Updated license field to use SPDX expression.
  • Increased setuptools version requirement to >=77.0.
  • Removed redundant license classifier entry.
  • +2/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @CLAassistant
    Copy link

    CLA assistant check
    Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
    You have signed the CLA already but the status is still pending? Let us recheck it.

    @qodo-code-review
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cdce8p
    Copy link
    Author

    cdce8p commented Mar 23, 2025

    Unfortunately, I'm not signing a CLA just for a 3 line change in the metadata.
    Going to close this one but please feel free to reuse any part of it if you like.

    @cdce8p cdce8p closed this Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants