-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Closed
Labels
B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better
Description
Description
Example:
browsingContext.Info = {
children: browsingContext.InfoList / null,
clientWindow: browser.ClientWindow,
? parent: browsingContext.BrowsingContext / null,
}
In .net it should be:
public record BrowsingContextInfo(IReadOnlyList<BrowsingContextInfo>? Children, Browser.ClientWindow ClientWindow)
{
[JsonInclude]
public BrowsingContext? Parent { get; internal set; }
}
So, children
prop is in ctor (as for now), BUT it should be nullable because of browsingContext.InfoList / null
. This is only about it: review all / null
entries in spec and make appropriate type as nullable
.
Have you considered any alternatives or workarounds?
No response
Metadata
Metadata
Assignees
Labels
B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better