[py] Better error for downloads on local webdrivers

[cgoldberg]

User description

🔗 Related Issues

Fixes #15753

💥 What does this PR do?

This PR raises NotImplementedError when trying to call get_downloadable_files() or download_file() on any local WebDriver. These methods are only available on the parent WebDriver class (AKA Remote).

This just makes the error thrown a little less cryptic for the user.

🔄 Types of changes

• Bug fix

---

PR Type

Bug fix

---

Description

• Raise NotImplementedError for download methods on local drivers

• Improve error clarity for unsupported download operations

• Affects Chromium, Firefox, IE, Safari, WebKitGTK, and WPEWebKit drivers

---

Changes walkthrough 📝

Relevant files

Bug fix

webdriver.py Add NotImplementedError for download methods in Chromium driver py/selenium/webdriver/chromium/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0      webdriver.py Add NotImplementedError for download methods in Firefox driver py/selenium/webdriver/firefox/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0      webdriver.py Add NotImplementedError for download methods in IE driver py/selenium/webdriver/ie/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0      webdriver.py Add NotImplementedError for download methods in Safari driver py/selenium/webdriver/safari/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0      webdriver.py Add NotImplementedError for download methods in WebKitGTK driver py/selenium/webdriver/webkitgtk/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0      webdriver.py Add NotImplementedError for download methods in WPEWebKit driver py/selenium/webdriver/wpewebkit/webdriver.py Added download_file and get_downloadable_files methods Both methods now raise NotImplementedError +6/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Message The NotImplementedError is raised without a descriptive message explaining why these methods are not available on local WebDrivers or suggesting alternatives. raise NotImplementedError

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add descriptive error messages Add descriptive error messages to the NotImplementedError exceptions to inform users that these methods are not supported for local webdrivers. This provides clearer guidance on why the operation failed. py/selenium/webdriver/chromium/webdriver.py [226-230] def download_file(self, *args, **kwargs): - raise NotImplementedError + raise NotImplementedError("The download_file method is not supported for local webdrivers") def get_downloadable_files(self, *args, **kwargs): - raise NotImplementedError + raise NotImplementedError("The get_downloadable_files method is not supported for local webdrivers") Apply / Chat Suggestion importance[1-10]: 5 __ Why: Adding descriptive error messages to NotImplementedError improves developer experience by clarifying why the methods are not available, but it does not affect core functionality or correctness.	Low
Update