[🐛 Bug]: SE_SAFARIDRIVER is not respected in the java bindings or selenium-manager

[ShinySaana]

Description

I am trying to override /usr/bin/safaridriver as the safaridriver location, through a Grid Node. It seems ignored during my testing, and I cannot see a codepath that would allow it to be set through this env variable. To the contrary, I see it hardcoded in:

• selenium/java/src/org/openqa/selenium/safari/SafariDriverService.java

  Line 54 in 0fe5ed2

  private static final File SAFARI_DRIVER_EXECUTABLE = new File("/usr/bin/safaridriver");

• selenium/rust/src/safari.rs

  Line 113 in 0fe5ed2

  Ok(PathBuf::from("/usr/bin/safaridriver"))

If SE_SAFARIDRIVER is respected in python and ruby, why not in java or in selenium-manager?

Reproducible Code

# sh
SE_SAFARIDRIVER=/some/thing "$JAVA_HOME/bin/java" -jar selenium-server.jar node --log-level FINER

# py
safari_options = webdriver.SafariOptions()

driver = webdriver.Remote(
   command_executor="http://localhost:5555",
   options=safari_options
)
driver.get("https://www.google.com")


## The logs should show /usr/bin/safaridriver being used instead of /some/thing

[selenium-ci]

@ShinySaana, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

[diemol]

I don't think you can customize the Safari driver location. Can you provide the example with Ruby and Python you mention?

[ShinySaana]

From my understanding, the source of it being loaded in python and ruby is in these places:

• selenium/py/selenium/webdriver/safari/service.py

  Line 50 in 0fe5ed2

  driver_path_env_key = driver_path_env_key or "SE_SAFARIDRIVER"

• selenium/rb/lib/selenium/webdriver/safari/service.rb

  Line 27 in 0fe5ed2

  DRIVER_PATH_ENV_KEY = 'SE_SAFARIDRIVER'

I am not familiar enough with Selenium's codebase to affirm anything, but I do not see any codepath that would overrule the behaviour of SE_SAFARIDRIVER in these instances.

Furthermore, crudely sed-ing the output of selenium-manager to replace /usr/bin/safaridriver by the desired executable does make a Grid Node use it, with no apparent issues; as long as that executable behaves similarly as the original safaridriver.

[ShinySaana]

My confusion mostly stems from how some bindings support it, while others hardcode the executable path for no apparent reason.

[diemol]

Maybe in old versions it was possible to set a custom path of the binary, and perhaps that is why it is like that.

Currently, you cannot customize the binary location. More over, you cannot run two different Safari versions on the same machine. Read more at https://developer.apple.com/documentation/webkit/testing-with-webdriver-in-safari#Make-Sure-You-Have-Safaris-WebDriver

What are you trying to achieve?

[ShinySaana]

I am trying to use a different safaridriver than the one provided. That is all I am asking for, and what I am trying to achieve to that end has nothing to do with the conflicting behaviour between bindings.

[diemol]

I am not sure if that is possible. That is also out of the scope given that the limitation is placed by Safari. You might ask them directly,