[refactor] use constant CapabilityType.ENABLE_DOWNLOADS instead of hard-coded value se:downloadsEnabled
#15867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR replaces hard-coded value
se:downloadsEnabledin multiple places by proper constantCapabilityType.ENABLE_DOWNLOADS.🔧 Implementation Notes
One place could not be replaced:
org.openqa.selenium.HasDownloads.Because it's located in module "selenium-api" which cannot depend on module "selenium-remote" (where
HasDownloadsis located).🔄 Types of changes
PR Type
Enhancement, Bug fix
Description
Replaced hard-coded
se:downloadsEnabledwithCapabilityType.ENABLE_DOWNLOADSImproved code maintainability and consistency
Ensured tests use the constant for download capability
Changes walkthrough 📝
3 files
Use ENABLE_DOWNLOADS constant for managed downloads capabilityReplace hard-coded downloads capability with constantUse ENABLE_DOWNLOADS constant in managed downloads check7 files
Update test to use ENABLE_DOWNLOADS constantRefactor tests to use ENABLE_DOWNLOADS constantUse ENABLE_DOWNLOADS constant in test capabilitiesUpdate test to check downloads capability using constantUse ENABLE_DOWNLOADS constant for download capability in testsRefactor test to use ENABLE_DOWNLOADS constant in capabilitiesUse ENABLE_DOWNLOADS constant in remote driver test