-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Closed
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better
Description
Description
Currently we use v8
, with issue: dotnet/runtime#72604
We applied a workaround to avoid this issue. For Selenium team it is not a big deal to support this workaround.
Have you considered any alternatives or workarounds?
What if we upgrade to System.Text.Json v9
, meaning this workaround is no longer needed.
But if we upgrade, then we should get some benefits.
I can image the following benefits:
- Support polymorphic deserialization with unordered discriminator
Introduce deserialization fromStream
. Currently we are listening incoming WebSocket chunks, and start deserialization process as soon as all message's chunks are received. Ifv9
can help us to start deserialization process as soon as any chunk is available (fromStream
), then it can be beneficial. We should test it on large json payloads and see memory consumption. If memory usage decreases significantly, then it is good argument to upgrade.
Metadata
Metadata
Assignees
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better