Skip to content

Conversation

@lixiang2017
Copy link

@lixiang2017 lixiang2017 commented Aug 25, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Fix typos in python

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Other

PR Type

Documentation


Description

  • Fixed incorrect docstring for until_not method

  • Corrected description to reflect method waits for False value


File Walkthrough

Relevant files
Documentation
wait.py
Fix until_not method docstring accuracy                                   

py/selenium/webdriver/support/wait.py

  • Corrected docstring for until_not method to accurately describe it
    waits for False value
  • Fixed misleading documentation that incorrectly stated method waits
    for non-False values
+2/-2     

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2025

CLA assistant check
All committers have signed the CLA.

@selenium-ci selenium-ci added C-py Python Bindings B-support Issue or PR related to support classes labels Aug 25, 2025
@qodo-merge-pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1234 - Partially compliant

Compliant requirements:

Non-compliant requirements:

  • Investigate and fix regression for JavaScript-in-href click behavior.
  • Validate behavior parity with 2.47.1 and provide verification steps.
  • Confirm fix on Firefox 42.0.

Requires further human verification:

  • End-to-end browser testing to confirm JavaScript-in-href clicks behave as expected across versions.

5678 - Partially compliant

Compliant requirements:

Non-compliant requirements:

  • Resolve ConnectFailure on multiple ChromeDriver instantiations.
  • Ensure stability for subsequent instances and provide guidance.

Requires further human verification:

  • Reproduction with specified OS, Chrome/ChromeDriver versions to validate stability.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Behavior Mismatch

The updated docstring states that until_not waits until the method returns a value that is False. Traditionally, until_not waits until the condition becomes False (i.e., the method evaluates to False), at which point it should return True (or the condition value). Verify that the function's actual return contract and behavior align with this description; otherwise, the docstring may still be misleading.

"""Wait until the method returns a value that is False.

Calls the method provided with the driver as an argument until the
return value evaluates to ``False``.

@selenium-ci
Copy link
Member

Thank you, @lixiang2017 for this code suggestion.

The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.

We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@cgoldberg
Copy link
Member

There is no "typo", and the proposed change describes the exact opposite of what it does.

@cgoldberg cgoldberg closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-support Issue or PR related to support classes C-py Python Bindings Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants