-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Open
Labels
B-buildIncludes scripting, bazel and CI integrationsIncludes scripting, bazel and CI integrationsD-chromeI-defectSomething is not working as intendedSomething is not working as intended
Description
Description
The Chromium team has changed the way the browser_protocol.pdl file is created. Previously it used to be one big file with all the DevTools domains in there;
https://raw.githubusercontent.com/chromium/chromium/140.0.7339.80/third_party/blink/public/devtools_protocol/browser_protocol.pdl
It got changed to use #include statements and points to separate files per domain;
https://raw.githubusercontent.com/chromium/chromium/141.0.7390.7/third_party/blink/public/devtools_protocol/browser_protocol.pdl
This causes the Bazel build to fail because it doesn't load the domain files.
Reproducible Code
Taken from GenerateSeleniumFiles.ps1
Write-Host "Downloading browser_protocol.pdl for Chromium $FullVersion."
$ProgressPreference = 0
$browserProtocolPdl = (Invoke-WebRequest -Uri "https://raw.githubusercontent.com/chromium/chromium/$FullVersion/third_party/blink/public/devtools_protocol/browser_protocol.pdl").Content
$browserProtocolPdl = $browserProtocolPdl -replace ' number expires', ' optional number expires'
$encoding = [System.Text.UTF8Encoding]::new($false)
[System.IO.File]::WriteAllText((Join-Path $commonDevToolsChromiumNew 'browser_protocol.pdl'), $browserProtocolPdl, $encoding)
ℹ️ Last known working version: Chromium 140, upstream change
Metadata
Metadata
Assignees
Labels
B-buildIncludes scripting, bazel and CI integrationsIncludes scripting, bazel and CI integrationsD-chromeI-defectSomething is not working as intendedSomething is not working as intended