[🐛 Bug]: Building Selenium Atoms fails on a MacBookPro M4 (ARM64)

[whimboo]

Description

I'm trying to build some Selenium atoms on my MacBookPro M4 but the build process fails with:

Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Analyzed target //javascript/atoms/fragments:get-text (187 packages loaded, 2481 targets configured).
INFO: Found 1 target...
ERROR: /private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/external/com_google_dagger/BUILD:7:12: Extracting interface @com_google_dagger//:runtime [for host] failed: (Exit 1): ijar failed: error executing command
  (cd /private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/sandbox/darwin-sandbox/4/execroot/selenium && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  external/remote_java_tools_darwin/java_tools/ijar/ijar external/com_google_dagger/dagger-2.14.1.jar bazel-out/host/bin/external/com_google_dagger/_ijar/runtime/dagger-2.14.1-ijar.jar --target_label @com_google_dagger//:runtime)
# Configuration: edc327570c55dd660daf217ec64d0ee7e1ae72c76baa3e8c0dc2bca0ee5d9c9f
# Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/process-wrapper-legacy.cc:80: "execvp(external/remote_java_tools_darwin/java_tools/ijar/ijar, ...)": Bad CPU type in executable
ERROR: /private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/external/com_google_closure_stylesheets/BUILD:7:12: Extracting interface @com_google_closure_stylesheets//:com_google_closure_stylesheets [for host] failed: (Exit 1): ijar failed: error executing command
  (cd /private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/sandbox/darwin-sandbox/5/execroot/selenium && \
  exec env - \
    PATH=/bin:/usr/bin:/usr/local/bin \
  external/remote_java_tools_darwin/java_tools/ijar/ijar external/com_google_closure_stylesheets/closure-stylesheets-1.5.0.jar bazel-out/host/bin/external/com_google_closure_stylesheets/_ijar/com_google_closure_stylesheets/closure-stylesheets-1.5.0-ijar.jar --target_label @com_google_closure_stylesheets//:com_google_closure_stylesheets)
# Configuration: edc327570c55dd660daf217ec64d0ee7e1ae72c76baa3e8c0dc2bca0ee5d9c9f
# Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/main/tools/process-wrapper-legacy.cc:80: "execvp(external/remote_java_tools_darwin/java_tools/ijar/ijar, ...)": Bad CPU type in executable
Target //javascript/atoms/fragments:get-text failed to build
INFO: Elapsed time: 74.707s, Critical Path: 0.18s
INFO: 756 processes: 755 internal, 1 darwin-sandbox.
FAILED: Build did NOT complete successfully

As it can be seen binaries for the x86_64 architecture are downloaded but not for aarch64:

 file /private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/external/remote_java_tools_darwin/java_tools/ijar/ijar
/private/var/tmp/_bazel_henrik/b58f0477e3b952dea2f48025db663106/external/remote_java_tools_darwin/java_tools/ijar/ijar: Mach-O 64-bit executable x86_64

Reproducible Code

Just try to run:

> bazel build //javascript/atoms/fragments:get-text

---

ℹ️ Last known working version: not sure I didn't build for quite some time

[selenium-ci]

@whimboo, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

[shs96c]

First of all, please run bazel --version in the repo. The value displayed should match whatever is in .bazelversion. If it doesn't, the most likely explanation is that you installed a specific version of bazel instead of the bazelisk wrapper. The best thing to do in this case is to uninstall bazel and then install bazelisk. Most OSs can do this through their package manager, but you can also do this manually. Somewhat confusingly, add bazelisk to your PATH as bazel. Now when you execute a build, the correct version of bazel will be downloaded and used.

Secondly, make sure that your Java installation is for Apple silicon and not for x86. Because of Rosetta, you may have an old version of java on the command line.

If neither of those things makes a difference, please reply to this issue, and we'll debug it further.

[whimboo]

I have first installed bazel myself but then removed it immediately on this kinda new machine when I read about bazelisk. So the version that is currently installed is bazel 5.3.0, which matches what Selenium wants to have.

Regarding Java I needed to setup this machine recently from a blank state. There was no Java installed before and this morning I installed OpenJDK17U-jdk_aarch64_mac_hotspot_17.0.16_8.pkg which is clearly the required architecture: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e].

[shs96c]

Bazel 5.3.0 is ancient. In the .bazelversion file, we have 7.4.1. Java 17 should be fine, but you're not using the right bazel version. You may need to link bazel to bazelisk, but you can check by running bazelisk --version

[whimboo]

Hm, this is strange. So I thought that it automatically uses the version as specified in the .bazelversion file as per documentation:

Otherwise, if a .bazelversion file exists in the current directory or recursively any parent directory, it will read the file and use the version specified in it.

Also forcing to use version 7.4.1 with the USE_BAZEL_VERSION environment variable doesn't make a difference:

✗ USE_BAZEL_VERSION=7.4.1 bazel build //javascript/atoms/fragments:get-text
Starting local Bazel server and connecting to it...
ERROR: Traceback (most recent call last):
	File "/Users/henrik/code/selenium/WORKSPACE", line 1, column 10, in <toplevel>
		workspace(
Error in workspace: workspace() got unexpected keyword argument 'managed_directories'
ERROR: Error computing the main repository mapping: Encountered error while reading extension file 'defs.bzl': no such package '@@python_version//': error loading package 'external': Could not load //external package

[shs96c]

You have most assuredly got an old Bazel binary. If you download bazelisk from https://github.com/bazelbuild/bazelisk/releases/tag/v1.27.0 and then run ./bazelisk build //javascript/atoms/fragments:get-text what happens? If the build passes, run which bazel and replace that binary with the bazelisk one you downloaded. Most typical installations will have symlinked bazelisk (the actual binary) to bazel

[whimboo]

I have installed bazelisk via homebrew and I have /opt/homebrew/bin/bazel -> ../Cellar/bazelisk/1.27.0/bin/bazel so exactly the version you are referencing. Using bazelisk instead of bazel to run the build command doesn't make any difference, the same error is raised. :(

Also downloading the bazelisk binary from the project's repository doesn't make a difference. I'm still running into the same error.

[whimboo]

@shs96c helped me via Matrix. When I did my pull yesterday I seem to not have pulled correctly from this repository. The changeset I was on is from around August 2022. So no wonder why it's not working.

Updating to the latest changeset fixed the issue and I can correctly build the atoms now.

Thanks!